Migrate to Pytest #368

vmuriart · 2017-02-08T18:59:46Z

What does this implement/fix? Explain your changes.

Unittests module requires alot of boilerplate setup to get running. Pytest the process of unittest writing within python making it easier for new contributors to add tests.
Any test can be run by itself again, instead of having to run the entire test suite.

Does this close any currently open issues?

N/A

Any other comments?

This was the original meant to be part of #329 but decided to separate it out.

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself to AUTHORS
Updated the CHANGELOG

vmuriart · 2017-02-08T19:04:24Z

Also another nice feature is that it has a nicer output

$ python -m pytest
============================= test session starts ==============================
platform linux -- Python 3.3.5, pytest-3.0.6, py-1.4.32, pluggy-0.4.0
rootdir: /home/travis/build/pythonnet/pythonnet, inifile: setup.cfg
collected 360 items 
src/tests/test_array.py ........................................
src/tests/test_callback.py ..
src/tests/test_class.py ..................
src/tests/test_compat.py ................
src/tests/test_constructors.py ....
src/tests/test_conversion.py ....................
src/tests/test_delegate.py .................
src/tests/test_docstring.py ...
src/tests/test_engine.py .ss
src/tests/test_enum.py ...............
src/tests/test_event.py ............................
src/tests/test_exceptions.py .........................
src/tests/test_field.py ..............................
src/tests/test_generic.py .................
src/tests/test_import.py .
src/tests/test_indexer.py .............................
src/tests/test_interface.py ....
src/tests/test_method.py ........................................
src/tests/test_module.py ...........................
src/tests/test_property.py ..........
src/tests/test_recursive_types.py .
src/tests/test_subclass.py sssss.
src/tests/test_sysargv.py .
src/tests/test_thread.py ...

vs

$ python src/tests/runtests.py
Load clr import hook
.................................................................................................................................s.............................................................................................................................................................................................................................s.ssssss.
----------------------------------------------------------------------
Ran 360 tests in 2.367s
OK (skipped=8)

codecov · 2017-02-08T19:31:52Z

Codecov Report

Merging #368 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   63.08%   63.18%   +0.09%     
==========================================
  Files          61       61              
  Lines        5239     5239              
  Branches      876      876              
==========================================
+ Hits         3305     3310       +5     
+ Misses       1715     1709       -6     
- Partials      219      220       +1

Impacted Files	Coverage Δ
src/runtime/pythonexception.cs	`64.28% <ø> (-1.79%)`	❌
src/runtime/assemblymanager.cs	`89.78% <ø> (+1.07%)`	✅
src/runtime/moduleobject.cs	`84.39% <ø> (+2.31%)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d325f...76aa731. Read the comment docs.

filmor

This is a very good idea. We just need to fix the conda recipe, too.

filmor · 2017-02-08T19:50:27Z

MANIFEST.in

@@ -0,0 +1,20 @@
+graft docs


What is this file for?

I forgot to remove that commit/file. Its supposed to replace the _get_source_files in setup.py.
I didn't get around to testing it though. Removing it fixes the conda recipe.

Let me fix that.

Same question

vmuriart · 2017-02-08T20:07:51Z

@filmor @denfromufa conda recipe fixed.
I wrote that MANIFEST.in a while back, it was referring to a docs folder we had i think.

vmuriart · 2017-02-08T22:08:00Z

All builds finished, none of them had the conda.recipe build error from the manifest. Looks like we are good to merge then?

den-run-ai · 2017-02-09T02:33:56Z

I like the switch to pytest, can you give 1-2 days to review this and test locally? @vmuriart

vmuriart · 2017-02-09T02:38:50Z

Sure. Test wise, nothing changed other than indent level.
Have you tried using tox for testing? It will let you run against all interpreters you have installed.

den-run-ai · 2017-02-09T03:15:31Z

Even PyPy ;)

…

On Wed, Feb 8, 2017, 8:38 PM Victor Uriarte ***@***.***> wrote: Sure. Test wise, nothing changed other than indent level. Have you tried using tox for testing? It will let you run against all interpreters you have installed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#368 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgZ5X_DQ7KgYJQDZTxogIfb8MNoSmYdks5ranw7gaJpZM4L7OID> .

vmuriart · 2017-02-09T03:29:46Z

You can configure it for it; though idk if pythonnet would have any issues w it.

vmuriart · 2017-02-13T14:39:19Z

@denfromufa did you get a chance to finish testing?

den-run-ai · 2017-02-13T14:48:36Z

Sorry, PyPy got me distracted. Let me try pytest tonight. If not, then you can merge tomorrow.

…

On Mon, Feb 13, 2017, 8:39 AM Victor Uriarte ***@***.***> wrote: @denfromufa <https://github.com/denfromufa> did you get a chance to finish testing? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#368 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgZ5d27xZjOSol_YidLnO0iIPy6bfFzks5rcGsYgaJpZM4L7OID> .

pytest on travis initially required `sudo=required` otherwise failed. Without the sudo flag pytest wasn't being upgraded. Needed to force upgrade. pytest-dev/pytest#2240

Needs local imports to work. Conversion done with unittests2pytests and a couple regex

Control settings for some add-ons like pytest

vmuriart requested review from filmor, tonyroberts and den-run-ai February 8, 2017 19:02

vmuriart self-assigned this Feb 8, 2017

vmuriart added the decision label Feb 8, 2017

filmor approved these changes Feb 8, 2017

View reviewed changes

vmuriart force-pushed the pytest branch from ecdd498 to 913bc9a Compare February 8, 2017 20:03

vmuriart force-pushed the pytest branch from 913bc9a to 0b8ebe1 Compare February 9, 2017 02:42

vmuriart removed the decision label Feb 13, 2017

vmuriart added 4 commits February 13, 2017 15:18

Add pytest to CI

ba7794b

pytest on travis initially required `sudo=required` otherwise failed. Without the sudo flag pytest wasn't being upgraded. Needed to force upgrade. pytest-dev/pytest#2240

Convert unittest to pytest

1ea29c7

Needs local imports to work. Conversion done with unittests2pytests and a couple regex

Add setup.cfg

104ef71

Control settings for some add-ons like pytest

Simpler tox

76aa731

vmuriart force-pushed the pytest branch from 0b8ebe1 to 76aa731 Compare February 13, 2017 22:29

vmuriart merged commit 76aa731 into pythonnet:master Feb 14, 2017

vmuriart added a commit that referenced this pull request Feb 14, 2017

Merge pull request #368 from vmuriart/pytest

13e2a87

vmuriart deleted the pytest branch February 14, 2017 11:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate to Pytest #368

Migrate to Pytest #368

Uh oh!

vmuriart commented Feb 8, 2017 •

edited

Loading

Uh oh!

vmuriart commented Feb 8, 2017 •

edited

Loading

Uh oh!

codecov bot commented Feb 8, 2017 •

edited

Loading

Uh oh!

filmor left a comment

Uh oh!

filmor Feb 8, 2017

Uh oh!

vmuriart Feb 8, 2017

Uh oh!

den-run-ai Feb 8, 2017

Uh oh!

vmuriart commented Feb 8, 2017

Uh oh!

vmuriart commented Feb 8, 2017

Uh oh!

den-run-ai commented Feb 9, 2017 •

edited

Loading

Uh oh!

vmuriart commented Feb 9, 2017

Uh oh!

den-run-ai commented Feb 9, 2017 via email

Uh oh!

vmuriart commented Feb 9, 2017

Uh oh!

vmuriart commented Feb 13, 2017

Uh oh!

den-run-ai commented Feb 13, 2017 via email

Uh oh!

Uh oh!

Migrate to Pytest #368

Migrate to Pytest #368

Uh oh!

Conversation

vmuriart commented Feb 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Any other comments?

Checklist

Uh oh!

vmuriart commented Feb 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

filmor left a comment

Choose a reason for hiding this comment

Uh oh!

filmor Feb 8, 2017

Choose a reason for hiding this comment

Uh oh!

vmuriart Feb 8, 2017

Choose a reason for hiding this comment

Uh oh!

den-run-ai Feb 8, 2017

Choose a reason for hiding this comment

Uh oh!

vmuriart commented Feb 8, 2017

Uh oh!

vmuriart commented Feb 8, 2017

Uh oh!

den-run-ai commented Feb 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vmuriart commented Feb 9, 2017

Uh oh!

den-run-ai commented Feb 9, 2017 via email

Uh oh!

vmuriart commented Feb 9, 2017

Uh oh!

vmuriart commented Feb 13, 2017

Uh oh!

den-run-ai commented Feb 13, 2017 via email

Uh oh!

Uh oh!

vmuriart commented Feb 8, 2017 •

edited

Loading

vmuriart commented Feb 8, 2017 •

edited

Loading

codecov bot commented Feb 8, 2017 •

edited

Loading

den-run-ai commented Feb 9, 2017 •

edited

Loading