Added side-by-side VS 2017 build with NetStandard 1.5 support. #444

dmitriyse · 2017-03-28T17:33:39Z

What does this implement/fix? Explain your changes.

Added new files that allows to build PythonNet targeting NetStarndard 1.5
Current build scripts are not affected.

All code modification should be loss-less for current build configurations.

New VS 2017 build files are capable to build net40 and NetStandard 1.5 assemblies.

This change is a first CoreCLR compilable version. Probably it is not functional yet.
The work is in progress.

Also CoreCLR assembly/package now have 3.0.0-alpha version. Probably it's ok, if PythonNet with CoreCLR support is scheduled to 3.0.0
...

Does this close any currently open issues?

Not closes yet but relates to #96
...

Any other comments?

We can join this branch into the master even now, and continue to develop with the additional target (NetStandard 1.5).
But it is reasonable to do it after the point where both Windows and Linux configurations will be tested.
...

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself to AUTHORS
Updated the CHANGELOG

…karound.

… debugged.

mention-bot · 2017-03-28T17:33:39Z

Unable to parse mention-bot custom configuration file due to a syntax error.
Please check the potential root causes below:

Having comments
Invalid JSON type
Having extra "," in the last JSON attribute

Error message:

Error: Parse error on line 2:
... "maxReviewers": 5, // Maximum  number o
-----------------------^
Expecting 'STRING', got 'undefined'

mention-bot · 2017-03-28T17:33:40Z

@dmitriyse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vmuriart, @tonyroberts and @tiran to be potential reviewers.

dmitriyse · 2017-03-28T17:47:57Z

I will inject ReflectionBridge right into PythonNet, to save single-Dll deployments.

codecov · 2017-03-28T18:11:43Z

Codecov Report

Merging #444 into master will decrease coverage by 10.47%.
The diff coverage is 59.7%.

@@             Coverage Diff             @@
##           master     #444       +/-   ##
===========================================
- Coverage   77.03%   66.56%   -10.48%     
===========================================
  Files          62       63        +1     
  Lines        5526     5270      -256     
  Branches      886      843       -43     
===========================================
- Hits         4257     3508      -749     
- Misses        981     1506      +525     
+ Partials      288      256       -32

Flag	Coverage Δ
#setup_linux	`74.76% <ø> (-0.96%)`	⬇️
#setup_windows	`65.88% <59.7%> (-10.51%)`	⬇️

Impacted Files	Coverage Δ
src/runtime/interfaceobject.cs	`50% <ø> (ø)`	⬆️
src/runtime/codegenerator.cs	`80% <ø> (ø)`	⬆️
src/runtime/genericutil.cs	`85.93% <ø> (ø)`	⬆️
src/runtime/debughelper.cs	`0% <ø> (ø)`	⬆️
src/runtime/delegateobject.cs	`58.53% <ø> (-7.38%)`	⬇️
src/runtime/importhook.cs	`78.01% <ø> (-2.41%)`	⬇️
src/runtime/methodwrapper.cs	`85.71% <ø> (ø)`	⬆️
src/runtime/propertyobject.cs	`70% <ø> (ø)`	⬆️
src/runtime/metatype.cs	`69.1% <ø> (-2.45%)`	⬇️
src/runtime/eventobject.cs	`78.2% <ø> (ø)`	⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e66f0...45eaa72. Read the comment docs.

…net40 build.

vmuriart · 2017-04-02T19:06:24Z

Alot of your changes are also changing the encoding of the files.
I'll review this in more detail, but I think there's still room to improve compatibility to avoid having multiple #if NETSTANDARD 1.5 sections.

den-run-ai · 2017-04-22T04:16:15Z

@vmuriart did you have a chance to review this .net core integration?

vmuriart · 2017-04-24T15:21:34Z

Very much against it in the current form.

Adds too many build directives, making the code complicated. We just removed a bunch of them for PY2/PY3, don't want to readd them now for this
No new CI added for .net core. If something is added and breaks we won't know.

A better path would be to either refactor some more or completely move to it.

den-run-ai · 2017-04-24T15:55:35Z

@dmitriyse @vmuriart We can't move completely to .NET Core, it doesn't support DllExport and demo apps will break. So .NET Framework should still be tested.

…

On Mon, Apr 24, 2017, 10:21 AM Victor Uriarte ***@***.***> wrote: Very much against it in the current form. - Adds too many build directives, making the code complicated. We just removed a bunch of them for PY2/PY3, don't want to readd them now for this - No new CI added for .net core. If something is added and breaks we won't know. A better path would be to either refactor some more or completely move to it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#444 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgZ5fH4IyM3-bqj37qORAhslOt1VA7bks5rzL4BgaJpZM4Mr81i> .

Public constants replaced to static readonly fields. Relaxed platform binding.

den-run-ai · 2017-08-10T06:54:27Z

@dmitriyse can we close this pull request, or is this still part of other pull requests for .NET Core support?

dmitriyse · 2017-08-10T12:11:01Z

Yes, we can definitely close this PR. It's outdated. We will not support .NetStandard lower than 2.0.

dse added 7 commits March 28, 2017 15:11

DotNet core migration first files.

8bbf07c

Net 4.0 compilation fixed. NetStandard 1.5 dependencies added.

d279a59

Adoption for .Net Standard 1.5 completed, except ICustomMarshaler wor…

c654771

…karound.

Custom Marshaler workaround for NetStandard 1.5 implemented.

4e19934

New .Net 4.5+ reflection API polyfill implemented.

96f14f0

Migration issues resolved for Python3+Windows+x64. Compilable but not…

c53c3e9

… debugged.

CHANGELOG edited.

4875302

ReflectionBridge extension sources injected. Build fix.

e4ad620

dmitriyse force-pushed the coreclr branch from 9a6bbf9 to e4ad620 Compare March 28, 2017 18:17

dse added 4 commits March 28, 2017 22:18

Merge

7fe824c

Added embed_tests project to VS 2017 build. All tests are passed for …

26966d3

…net40 build.

DotNetCore + Windows x64 + Python 3.5 = all tests passed.

36c2e85

DotNetCore + Ubuntu 14.04 x64 + Python 3.5 = all tests passed.

563a844

dmitriyse force-pushed the coreclr branch 2 times, most recently from 7ec0c02 to 563a844 Compare March 30, 2017 23:22

den-run-ai added the requires review label Apr 21, 2017

vmuriart self-requested a review April 25, 2017 02:01

dse added 5 commits April 25, 2017 21:38

Binary substitution of Python.Runtime.Dll becomes safe.

9429512

Public constants replaced to static readonly fields. Relaxed platform binding.

Merge

a2ff2d8

Build fix, lost renames performed.

49edf48

Merge

d2ebd3a

typo fix.

938030c

dse and others added 2 commits April 25, 2017 23:17

Merge

5ff01dc

Merge branch 'master' into coreclr

45eaa72

den-run-ai closed this Aug 10, 2017

dmitriyse deleted the coreclr branch November 17, 2017 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added side-by-side VS 2017 build with NetStandard 1.5 support. #444

Added side-by-side VS 2017 build with NetStandard 1.5 support. #444

dmitriyse commented Mar 28, 2017 •

edited

Loading

mention-bot commented Mar 28, 2017

mention-bot commented Mar 28, 2017

dmitriyse commented Mar 28, 2017

codecov bot commented Mar 28, 2017 •

edited

Loading

vmuriart commented Apr 2, 2017

den-run-ai commented Apr 22, 2017

vmuriart commented Apr 24, 2017

den-run-ai commented Apr 24, 2017 via email •

edited

Loading

den-run-ai commented Aug 10, 2017

dmitriyse commented Aug 10, 2017

Added side-by-side VS 2017 build with NetStandard 1.5 support. #444

Added side-by-side VS 2017 build with NetStandard 1.5 support. #444

Conversation

dmitriyse commented Mar 28, 2017 • edited Loading

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Any other comments?

Checklist

mention-bot commented Mar 28, 2017

mention-bot commented Mar 28, 2017

dmitriyse commented Mar 28, 2017

codecov bot commented Mar 28, 2017 • edited Loading

Codecov Report

vmuriart commented Apr 2, 2017

den-run-ai commented Apr 22, 2017

vmuriart commented Apr 24, 2017

den-run-ai commented Apr 24, 2017 via email • edited Loading

den-run-ai commented Aug 10, 2017

dmitriyse commented Aug 10, 2017

dmitriyse commented Mar 28, 2017 •

edited

Loading

codecov bot commented Mar 28, 2017 •

edited

Loading

den-run-ai commented Apr 24, 2017 via email •

edited

Loading