Added CoreCLR 2.0 build target. Compile issues fixed. #519

dmitriyse · 2017-07-29T09:32:34Z

What does this implement/fix? Explain your changes.

Added dotnet core 2.0 build target. All tests are passed under win, py35, x64.
...

Does this close any currently open issues?

Work towards #96
...

Any other comments?

After a half of a year CoreCLR 1.0 will go away, so we can only offer CoreCLR 2.0 support.

Porting to CoreCLR 2.0 is much simpler than to CoreCLR 1.0. So we can do all the work right in the master. Xplat build fortunately can coexist side-by-side with the current build.
(See #518)

...

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself to AUTHORS
Updated the CHANGELOG

mention-bot · 2017-07-29T09:32:36Z

@dmitriyse, thanks! @vmuriart, @tiran, @brianlloyd, @filmor and @tonyroberts, please review this.

codecov · 2017-07-29T10:07:13Z

Codecov Report

Merging #519 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   77.34%   77.16%   -0.19%     
==========================================
  Files          65       65              
  Lines        5611     5610       -1     
  Branches      889      888       -1     
==========================================
- Hits         4340     4329      -11     
- Misses        983      993      +10     
  Partials      288      288

Flag	Coverage Δ
#setup_linux	`73.64% <100%> (+0.19%)`	⬆️
#setup_windows	`76.31% <100%> (-0.19%)`	⬇️

Impacted Files	Coverage Δ
src/runtime/nativecall.cs	`100% <ø> (+2.22%)`	⬆️
src/runtime/runtime.cs	`90.98% <ø> (ø)`	⬆️
src/runtime/pyobject.cs	`38.85% <100%> (-0.29%)`	⬇️
src/runtime/pyscope.cs	`57.71% <100%> (-1%)`	⬇️
setup.py	`89.81% <100%> (+0.07%)`	⬆️
src/runtime/pythonexception.cs	`64.28% <100%> (-14.29%)`	⬇️
src/runtime/metatype.cs	`71.55% <100%> (ø)`	⬆️
src/runtime/delegatemanager.cs	`88.18% <100%> (-0.32%)`	⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b381bf...441dacf. Read the comment docs.

dmitriyse · 2017-07-29T13:39:16Z

Tested under windows, miniconda python 3.5, x64. All tests are passed.

den-run-ai · 2017-07-31T05:51:48Z

@dmitriyse why do you have 2 similar pull requests?

dmitriyse · 2017-07-31T07:51:13Z

This #518 PR contains only new build system which is able to build all current targets for windows and linux. And contains absolutely minimum changes in the code.

But this request contains NetStandard 2.0 build target + fixes in code to allow compile and pass tests.

dmitriyse · 2017-07-31T08:00:18Z

Please see this comment #518 (comment), this PR should add new build target after #518 will be merged into the master.

den-run-ai · 2017-08-08T16:39:39Z

@dmitriyse can you merge these 2 PR? I still don't understand why you separated them? And I still don't see any testing done for .NET Core target.

dmitriyse · 2017-08-08T22:36:46Z

@dmitriyse can you merge these 2 PR? I still don't understand why you separated them? And I still don't see any testing done for .NET Core target.

@denfromufa
Please see this comment #518 (comment)

…ld).

dmitriyse · 2017-08-21T22:42:12Z

Debug session finished. I need to fix points received from this session.
All such imports:

        [DllImport(_PythonDll, CallingConvention = CallingConvention.Cdecl)]
        internal static extern int PyDict_SetItemString(IntPtr pointer, string key, IntPtr value);

Should be modified to

        [DllImport(_PythonDll, CallingConvention = CallingConvention.Cdecl, CharSet = CharSet.Ansi)]
        internal static extern int PyDict_SetItemString(IntPtr pointer, string key, IntPtr value);

And other build script fixes.

dmitriyse · 2017-08-22T14:04:38Z

I managed to get EmbeddingTests works under NetCoreApp 2.0 target on all configurations except x86
x86 Support we can add later, once somebody will have enough time.

dmitriyse · 2017-08-22T14:11:38Z

Both targets (net40 and netcoreapp2.0) are build and tested in the same --xplat CI configuration. It's simpler to implement and saves some time on awaiting build result.

dmitriyse · 2017-08-22T14:40:09Z

Also I found a problem under NetCoreApp 2.0 - import "numpy" failed.

dmitriyse · 2017-08-22T18:30:16Z

This PR is ready for merging to the master.
Current work allows to use python from the NetCoreApp 2.0 x64.

There are two main missing features, that can be implemented later:

x86 Support for .NetCoreApp 2.0
Access to .NetCoreApp 2.0 libraries from the genuine python.

…o a slow Marshal-based solution. + x86 fix.

…d non relevant CI build faults.

DEBUG;TRACE fix for the case VS + non empty PYTHONNET_DEFINE_CONSTANTS

filmor

Same as #518, I think we should go ahead with the current state for now.

* Full featured xplat build. * NetCoreApp 2.0 target added, compile issues fixed, CI system improved. * .Net 45 TargetingPack System.XML.dll naming fix. (For xplat linux build). * Setup.py --xplat option refactored. Travis-ci build matrix extended. * AppVeyor matrix extended, xplat build added. * appveyor.yml yaml syntax fix. * NUnit dependency upgraded to 3.7. Changelog improved. * EmbeddingTest fixes, and stubs. * Fix for importing numpy and other python modules with native parts. * Changelog improved. * Build order improvement. * NetCoreApp 2.0 fix. EmitCalli does not supports cdecl. Falling-back to a slow Marshal-based solution. + x86 fix. * All finalizers are disabled until valid implementation. Helps to avoid non relevant CI build faults. * Mono builds now can be build on Windows. DEBUG;TRACE fix for the case VS + non empty PYTHONNET_DEFINE_CONSTANTS * Python.Runtime.dll now targets NetStandard2.0 inplace of NetCoreApp 2.0 * Wrong NETSTANDARD/NETCOREAPP define constant change. * Typo fix.

#518 #519 #546 merge fix

Full featured xplat build.

0abfde0

dmitriyse mentioned this pull request Jul 31, 2017

CoreCLR msbuild (xplat) support. Initial compilable version. #518

Merged

dse added 5 commits August 18, 2017 19:03

.Net 45 TargetingPack System.XML.dll naming fix. (For xplat linux bui…

8b0b399

…ld).

Setup.py --xplat option refactored. Travis-ci build matrix extended.

3f02c12

AppVeyor matrix extended, xplat build added.

78d5d46

appveyor.yml yaml syntax fix.

2dc1b47

NUnit dependency upgraded to 3.7. Changelog improved.

665b9d7

dmitriyse force-pushed the coreclr2 branch from b994cd3 to 41e9fa3 Compare August 21, 2017 15:32

den-run-ai requested review from filmor, tonyroberts and vmuriart August 21, 2017 16:10

dmitriyse force-pushed the coreclr2 branch from 3aec328 to 3e2bfe1 Compare August 22, 2017 07:51

EmbeddingTest fixes, and stubs.

504495e

dmitriyse force-pushed the coreclr2 branch 2 times, most recently from f7516e7 to 7bc892e Compare August 22, 2017 14:01

Fix for importing numpy and other python modules with native parts.

1cc9008

Build order improvement.

2ac981b

dse added 2 commits August 27, 2017 21:11

NetCoreApp 2.0 fix. EmitCalli does not supports cdecl. Falling-back t…

2edbc87

…o a slow Marshal-based solution. + x86 fix.

Changelog improved.

dac5a96

dmitriyse force-pushed the coreclr2 branch 5 times, most recently from cc7f5f8 to 307f1dd Compare August 28, 2017 13:12

dse added 2 commits September 4, 2017 18:39

All finalizers are disabled until valid implementation. Helps to avoi…

0852392

…d non relevant CI build faults.

NetCoreApp 2.0 target added, compile issues fixed, CI system improved.

d16100c

dmitriyse force-pushed the coreclr2 branch from 307f1dd to dac5a96 Compare September 4, 2017 14:44

Mono builds now can be build on Windows.

ed48618

DEBUG;TRACE fix for the case VS + non empty PYTHONNET_DEFINE_CONSTANTS

den-run-ai self-requested a review September 6, 2017 14:43

den-run-ai added the requires review label Sep 6, 2017

dse added 4 commits September 6, 2017 22:21

Python.Runtime.dll now targets NetStandard2.0 inplace of NetCoreApp 2.0

3069fe4

Merge

0ca9612

Wrong NETSTANDARD/NETCOREAPP define constant change.

afaca1b

Typo fix.

b20d134

dmitriyse mentioned this pull request Sep 6, 2017

.NET Core support and CoreCLR embedding - cross-platform API #96

Closed

Merge branch 'master' into coreclr2

441dacf

filmor approved these changes Sep 21, 2017

View reviewed changes

filmor merged commit df1c224 into pythonnet:master Sep 21, 2017

This was referenced Sep 21, 2017

Build system improvements pack - addressing comments to PR and some issues. #546

Merged

Python to CLR string marshaling LRU cache. #538

Closed

dmitriyse mentioned this pull request Sep 28, 2017

Interop methods with Py_ssize_t works differently in NetCoreApp 2.0 #531

Merged

4 tasks

dmitriyse pushed a commit that referenced this pull request Nov 16, 2017

Merge #519

4aa8b18

dmitriyse pushed a commit that referenced this pull request Nov 16, 2017

Backed #519, wrong merge!

43a9eb6

dmitriyse added a commit that referenced this pull request Nov 16, 2017

Merge pull request #573 from pythonnet/master-merge-fix

f5a002f

#518 #519 #546 merge fix

dmitriyse deleted the coreclr2 branch November 17, 2017 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added CoreCLR 2.0 build target. Compile issues fixed. #519

Added CoreCLR 2.0 build target. Compile issues fixed. #519

dmitriyse commented Jul 29, 2017 •

edited

Loading

mention-bot commented Jul 29, 2017

codecov bot commented Jul 29, 2017 •

edited

Loading

dmitriyse commented Jul 29, 2017

den-run-ai commented Jul 31, 2017

dmitriyse commented Jul 31, 2017

dmitriyse commented Jul 31, 2017

den-run-ai commented Aug 8, 2017 •

edited

Loading

dmitriyse commented Aug 8, 2017

dmitriyse commented Aug 21, 2017 •

edited

Loading

dmitriyse commented Aug 22, 2017

dmitriyse commented Aug 22, 2017

dmitriyse commented Aug 22, 2017

dmitriyse commented Aug 22, 2017

filmor left a comment

Added CoreCLR 2.0 build target. Compile issues fixed. #519

Added CoreCLR 2.0 build target. Compile issues fixed. #519

Conversation

dmitriyse commented Jul 29, 2017 • edited Loading

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Any other comments?

Checklist

mention-bot commented Jul 29, 2017

codecov bot commented Jul 29, 2017 • edited Loading

Codecov Report

dmitriyse commented Jul 29, 2017

den-run-ai commented Jul 31, 2017

dmitriyse commented Jul 31, 2017

dmitriyse commented Jul 31, 2017

den-run-ai commented Aug 8, 2017 • edited Loading

dmitriyse commented Aug 8, 2017

dmitriyse commented Aug 21, 2017 • edited Loading

dmitriyse commented Aug 22, 2017

dmitriyse commented Aug 22, 2017

dmitriyse commented Aug 22, 2017

dmitriyse commented Aug 22, 2017

filmor left a comment

Choose a reason for hiding this comment

dmitriyse commented Jul 29, 2017 •

edited

Loading

codecov bot commented Jul 29, 2017 •

edited

Loading

den-run-ai commented Aug 8, 2017 •

edited

Loading

dmitriyse commented Aug 21, 2017 •

edited

Loading