Fixed Second PythonEngine.Initialize call, all sensitive static variables now reseted. #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitriyse, thanks! @vmuriart, @tonyroberts, @cgohlke, @tiran and @hsoft, please review this. |
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
+ Coverage 68.55% 77.19% +8.64%
==========================================
Files 1 63 +62
Lines 283 5754 +5471
Branches 0 907 +907
==========================================
+ Hits 194 4442 +4248
- Misses 89 1013 +924
- Partials 0 299 +299
Continue to review full report at Codecov.
|
27905c8 to
f205d56
Compare
f205d56 to
e9e9051
Compare
4 tasks
ff7e5a1 to
a10b6cc
Compare
a10b6cc to
507edc9
Compare
den-run-ai
reviewed
Feb 10, 2018
CHANGELOG.md
Outdated
| @@ -21,6 +21,8 @@ This document follows the conventions laid out in [Keep a CHANGELOG][]. | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Fixed secondary PythonEngine.Initialize call, all sensitive static variables now reseted. | |||
| This is a hidden bug. Once python cleaning up enough memory, objects from previous engine run becomes corrupted. | |||
There was a problem hiding this comment.
please include reference to this PR
|
@dmitriyse can you please resolve a conflict in this PR? |
|
Yes, I will try to do it on this week. |
0345af2 to
257dcc6
Compare
filmor
approved these changes
Oct 29, 2018
|
@denfromufa Could you review this again? |
2145bf2 to
44d606b
Compare
…oduces bugs when CPython freeing up enough objects.
44d606b to
dbd5fdd
Compare
|
@filmor i don't see any obvious issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This change fixes hidden bug. Once python cleaning up enough memory, objects from previous engine run becomes corrupted and produces segfault.
...
Does this close any currently open issues?
It's required but not enough to fix this issue
#499
...
Any other comments?
Described problem never pop up, because ~PyObject currently does not called by the GC (due to some reasons). So many many time pythonnet lives without garbage collection with constant memory leak.
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG