Skip to content

Build system improvements pack - addressing comments to PR and some issues. #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2017
Merged

Build system improvements pack - addressing comments to PR and some issues. #546

merged 7 commits into from
Nov 7, 2017

Conversation

dmitriyse
Copy link
Contributor

What does this implement/fix? Explain your changes.

Fixes issues specified in reviews for PR #518 and PR #519 and fix for the issue #539

Does this close any currently open issues?

#539
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@mention-bot
Copy link

@dmitriyse, thanks! @vmuriart, @tonyroberts, @davidanthoff, @tiran and @rickardraysearch, please review this.

@dmitriyse
Copy link
Contributor Author

Please do not review this branch, until I commit and test all part of the solution.
I will notify when this branch will be ready to review and merge.

@dmitriyse dmitriyse mentioned this pull request Sep 21, 2017
Merged
@den-run-ai
Copy link
Contributor

@dmitriyse please use [WIP] in your PR title when it is Work In Progress.

@codecov
Copy link

codecov bot commented Sep 21, 2017 •
edited
Loading

Codecov Report

Merging #546 into master will decrease coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   77.16%   77.14%   -0.03%     
==========================================
  Files          65       65              
  Lines        5610     5617       +7     
  Branches      888      888              
==========================================
+ Hits         4329     4333       +4     
- Misses        993      996       +3     
  Partials      288      288
Flag Coverage Δ
#setup_linux 71.83% <0%> (-1.82%) ⬇️
#setup_windows 76.28% <71.42%> (-0.03%) ⬇️
Impacted Files Coverage Δ
setup.py 88.97% <71.42%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1c224...0273abf. Read the comment docs.

@den-run-ai den-run-ai changed the title Build system improvements pack addressing comments to PR and some issues. [WIP] Build system improvements pack addressing comments to PR and some issues. Sep 21, 2017
@dmitriyse
Copy link
Contributor Author

Thank you for the tip.

@dmitriyse dmitriyse force-pushed the build-improvements branch 4 times, most recently from d3c72ad to f1229bd Compare September 22, 2017 00:30
@dmitriyse dmitriyse changed the title [WIP] Build system improvements pack addressing comments to PR and some issues. Build system improvements pack addressing comments to PR and some issues. Sep 22, 2017
@dmitriyse
Copy link
Contributor Author

PR is ready !

  1. All comments to CoreCLR msbuild (xplat) support. Initial compilable version. #518 addressed.
  2. DotNet 2.0/ Net4.0 pdb,debug build options for Debug/Release configuration now specified correctly.
    (fixes problem when release builds for dotnet core 2.0 generates windows PDB format instead of portable pdb format)
  3. Fix for the langversion 6 is not recognized with msbuild or csc compiler in VS 2017 #539 issue
  4. PYTHONNET_INTEROP_FILE env var introduced to allow working with custom interop*.cs file inside IDE.
  5. pythonnet.15.sln is tested with Project Rider 2017.1.2 and result is "FULL SUPPORT".
    So we should plan when we remove "classic build" or at least make --xplat build as a default.

@dmitriyse dmitriyse changed the title Build system improvements pack addressing comments to PR and some issues. Build system improvements pack - addressing comments to PR and some issues. Sep 22, 2017
@dmitriyse
Copy link
Contributor Author

It's so good to be a member of the core team, now I can kill broken builds without waiting. :)

@dmitriyse dmitriyse mentioned this pull request Sep 28, 2017
Merged
4 tasks
@den-run-ai
Copy link
Contributor

@dmitriyse i think this is good to merge! if @vmuriart can take a quick look at code coverage failures, that's great, but that is not blocking this PR merge.

@fractus fractus mentioned this pull request Oct 15, 2017
Closed
4 tasks
@den-run-ai den-run-ai merged commit 75e5231 into pythonnet:master Nov 7, 2017
dmitriyse pushed a commit that referenced this pull request Nov 16, 2017
backout #546, wrong merge!
700b522
dmitriyse added a commit that referenced this pull request Nov 16, 2017
@dmitriyse
Merge pull request #573 from pythonnet/master-merge-fix
f5a002f 
#518 #519 #546 merge fix
@dmitriyse dmitriyse deleted the build-improvements branch November 17, 2017 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmor filmor filmor approved these changes

@den-run-ai den-run-ai den-run-ai approved these changes

@tonyroberts tonyroberts Awaiting requested review from tonyroberts

@vmuriart vmuriart Awaiting requested review from vmuriart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitriyse @mention-bot @den-run-ai @filmor