Skip to content

Marshalling fix for 3-IntPtr args cdecl calls. #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

Marshalling fix for 3-IntPtr args cdecl calls. #550

merged 1 commit into from
Dec 12, 2017

Conversation

dmitriyse
Copy link
Contributor

What does this implement/fix? Explain your changes.

Workaround for the DotNet Core 2.0 marshaling bug.
Problem described here #96 (comment)
...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@codecov
Copy link

codecov bot commented Oct 3, 2017 •
edited
Loading

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files          65       65           
  Lines        5617     5617           
  Branches      888      888           
=======================================
  Hits         4333     4333           
  Misses        996      996           
  Partials      288      288
Flag Coverage Δ
#setup_linux 71.83% <ø> (ø) ⬆️
#setup_windows 76.28% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/runtime/nativecall.cs 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a002f...580f13f. Read the comment docs.

@dmitriyse
Copy link
Contributor Author

Related CoreCLR bug described here https://github.com/dotnet/coreclr/issues/14362

@dmitriyse
Copy link
Contributor Author

It's a hot fix. That not fully solve the problem.
I created issue for the full solution #553

@den-run-ai
Copy link
Contributor

@dmitriyse is there any test for this "fix" or can you describe what issue you experienced? thanks for digging this through. also for the full potential fix in the future can you also describe a failing test?
finally this does not look like a bug in .net core, since this marshalling works as described in documentation.

@den-run-ai
Copy link
Contributor

@dmitriyse I just noticed that this fixed the issue that I experienced here: #96 (comment)

let me verify it quickly.

@den-run-ai
Copy link
Contributor

@dmitriyse your fix is verified.

@den-run-ai
Copy link
Contributor

@filmor @vmuriart please review, I think this is good to go!

@dmitriyse dmitriyse merged commit 46d56af into pythonnet:master Dec 12, 2017
@dmitriyse dmitriyse deleted the core2-marshal-fix branch December 12, 2017 23:57
@jmlidbetter jmlidbetter mentioned this pull request Aug 7, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@den-run-ai den-run-ai den-run-ai approved these changes

@filmor filmor Awaiting requested review from filmor

@tonyroberts tonyroberts Awaiting requested review from tonyroberts

@vmuriart vmuriart Awaiting requested review from vmuriart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitriyse @den-run-ai