Skip to content

Update CHANGELOG.md #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update CHANGELOG.md #621

wants to merge 2 commits into from

Conversation

Cronan
Copy link
Contributor

@Cronan Cronan commented Feb 7, 2018

Added fix for looking up types (in #622)

@codecov
Copy link

codecov bot commented Feb 7, 2018

Codecov Report

Merging #621 into master will increase coverage by 7.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
+ Coverage   69.42%   76.98%   +7.55%     
==========================================
  Files           1       64      +63     
  Lines         278     5609    +5331     
  Branches        0      888     +888     
==========================================
+ Hits          193     4318    +4125     
- Misses         85     1002     +917     
- Partials        0      289     +289
Flag Coverage Δ
#setup_linux 69.42% <ø> (ø) ⬆️
#setup_windows 76.16% <ø> (?)
Impacted Files Coverage Δ
src/runtime/methodobject.cs 73.23% <0%> (ø)
src/runtime/pyiter.cs 63.63% <0%> (ø)
src/runtime/interop33.cs 100% <0%> (ø)
src/runtime/interop.cs 95.73% <0%> (ø)
src/runtime/propertyobject.cs 70% <0%> (ø)
src/runtime/clrobject.cs 96.15% <0%> (ø)
src/runtime/assemblymanager.cs 89.78% <0%> (ø)
src/runtime/CustomMarshaler.cs 69.86% <0%> (ø)
src/runtime/pynumber.cs 100% <0%> (ø)
src/runtime/classobject.cs 74.19% <0%> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae0a6a...9b5846d. Read the comment docs.

@den-run-ai
Copy link
Contributor

@Cronan can you add a link to corresponding pull request or commit or issue?

@Cronan
Copy link
Contributor Author

Cronan commented Feb 7, 2018

@denfromufa Sorry, done

@den-run-ai
Copy link
Contributor

@Cronan how about adding it to changelog? :)

@Cronan
Copy link
Contributor Author

Cronan commented Feb 7, 2018

@denfromufa Gah, done o_O

@den-run-ai
Copy link
Contributor

@Cronan can you please include this pull request as part of #622

this is our normal workflow (you can see that from template)

@Cronan
Copy link
Contributor Author

Cronan commented Feb 7, 2018

Included as part of #622

@Cronan Cronan closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants