Added inline comment about dangers of multidomain usage #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@jakrivan please update the changelog and add yourself to authors. |
JanKrivanek
added a commit
to JanKrivanek/pythonnet
that referenced
this pull request
Jun 12, 2018
JanKrivanek
added a commit
to JanKrivanek/pythonnet
that referenced
this pull request
Jun 12, 2018
JanKrivanek
added a commit
to JanKrivanek/pythonnet
that referenced
this pull request
Jun 12, 2018
Codecov Report
@@ Coverage Diff @@
## featured #625 +/- ##
========================================
Coverage 76.6% 76.6%
========================================
Files 71 71
Lines 6023 6023
Branches 961 961
========================================
Hits 4614 4614
Misses 1080 1080
Partials 329 329
Continue to review full report at Codecov.
|
|
@denfromufa Thanks. Done |
|
Argh, didn't notice that this was against the "featured" branch. I'll cherry pick it on master... |
|
@filmor would you like to revert this PR from featured branch managed by @dmitriyse ? |
|
Not particularly, no. This is just an additional comment and the featured branch (as essentially a fork) shouldn't exist in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested here: #538 (comment)
What does this implement/fix? Explain your changes.
Just a commnet
Does this close any currently open issues?
No. But comment was requested
Any other comments?
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG