Update moduleobject.cs #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am a novice in English and pythonnet. But I am a Fan of pythonnet. The Proposed file is about NTFS Security. https://stackoverflow.com/questions/4496697/what-is-zone-identifier please check~
|
@icetiger1974 this seems legitimate, what kind of error does pythonnet show without this fix for these "unsecure" dlls? |
|
@icetiger1974 appveyor tests failing, weird. |
|
Hi, denfromufa. The exact error message to me was “FileNotFoundException: Unable to find assembly 'C:\DLL\myDLL.dll'.” |
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
- Coverage 76.89% 76.83% -0.06%
==========================================
Files 64 64
Lines 5583 5587 +4
Branches 889 891 +2
==========================================
Hits 4293 4293
- Misses 1000 1003 +3
- Partials 290 291 +1
Continue to review full report at Codecov.
|
|
@icetiger1974 merged, thanks! |
|
Hi denfromufa |
This was referenced Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a novice in English and pythonnet.
But I am a Fan of pythonnet.
The Proposed file is about NTFS Security.
https://stackoverflow.com/questions/4496697/what-is-zone-identifier
please check~
What does this implement/fix? Explain your changes.
... In case of Windows 10, We can find the DLL with Blocking.
.. But current code provides wrong information. So I modified these code lines
Does this close any currently open issues?
... I can not find open issues
Any other comments?
... none
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG