No reason except that we would like to test more scenarios. But feel free to merge and we’ll follow up with anything else we end up fixing. Cheers! David

Yes, I will make sure to write a unit test. Hopefully I can manage to figure out how to reproduce from scratch (the crash happens in the context of an application I do not have the code for); - execute Python code with Python .NET - app domain reload of the assembly - execute Python code with Pytjon .NET —> crash on second init when the runtime imports the « exception » module. The import hook « saved » original funtion ptr must be garbage at this point. Anyway, I will reopen the pull request or create a new one when everything is done. Thanks!

Hi Benedikt and Denis, I am working on a pull request to get my fix to this crash in the public repo. I created an issue: #714 I am now following the steps for contributing: https://github.com/pythonnet/pythonnet/blob/master/CONTRIBUTING.md About the branch name in my fork, is this ok: fix/develop/shutdown_on_domain_unload or should it be fix/lassond/shutdown_on_domain_unload Can you clarify these points for me please: * Make sure your commit messages are in the proper format What is the proper format? * Make sure you have added the necessary tests for your changes. * Run all the tests to assure nothing else was accidentally broken. Can you give me steps on how to run and add tests please? I created a standalone app that reproduces the crash. I will gladly try and translate it to a proper test. Thanks and keep up the good work, Python .NET is an impressive project! David On Thu, Jul 5, 2018 at 5:52 AM, David Lassonde < david.lassonde@imaginary-spaces.com> wrote: