Skip to content

Fix memory leaks due to spurious handle increment and add unit tests #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2018
Merged

Fix memory leaks due to spurious handle increment and add unit tests #704

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2e1bb2
Fix memory leaks and add unit tests
williamsardar Jul 20, 2018
aa222b3
Add changelog and authors entries
williamsardar Jul 20, 2018
b6c024c
Add new requirement for memory leak testing
williamsardar Jul 20, 2018
bcf9841
Update memory monitoring call to use a platform-independent field
williamsardar Jul 20, 2018
66d31bb
Delete commented code
williamsardar Jul 20, 2018
a97a776
Back out overzealous line deletion!
williamsardar Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete commented code
  • Loading branch information
@williamsardar
williamsardar committed Jul 20, 2018
commit 66d31bb5200e1e7d667d1ec0e36c7b3b6f0496cc
2 changes: 0 additions & 2 deletions src/runtime/constructorbinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ public static IntPtr mp_subscript(IntPtr op, IntPtr key)
}
var boundCtor = new BoundContructor(self.type, self.pyTypeHndl, self.ctorBinder, ci);

/* Since nothing is cached, do we need the increment???
Runtime.XIncref(boundCtor.pyHandle); // Decref'd by the interpreter??? */
return boundCtor.pyHandle;
}

Expand Down