@smourier what should be the logic if the types are not equal and they don't derive from one another?

Not sure what is going on with both CI, first time this happens! I just tried to restart some builds, but looks like the problem is on the github side.

I choose to modify the existing Comparer to minimize regression risks since I don't know this project much, and I don't know python much either :-).

Like I said, the whole Bind code that chooses what method should be taken is quite fragile (also I don't really understand the funky GetPrecedence algorithm?) and cannot support all different possibilities, it's not only a matter of sorting the methods.

If you want to support all the different types of methods that the .NET framework supports (including generics), you probably need to add some options that the caller could use on the python side, IMHO

PS: yes, github seems in trouble today!

github is still recovering from network/database failure:

https://blog.github.com/2018-10-21-october21-incident-report/

All existing tests are passing, but this new code needs a unit test.

@AlexCatarino this looks like a fix for your issue #552?

Yes, @denfromufa , thank you @smourier!

@smourier Thanks a lot for this patch, from my point of view this is good to go, but please, if possible

1. Add yourself to the AUTHORS file
2. Add a test
3. Add the fix to the Changelog

If you don't have the time for these, say the word and I'll complete the PR s.t. it can go into the next release :)

Well, originally, I was just answering a question on stackoverflow, so I let you guys the complete what needs to be :)

Although this is not yet released, I will close the question on StackOverflow because it does not need an answer anymore. Thanks for fixing this @smourier!

Codecov Report

Merging #756 into master will decrease coverage by 0.02%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   77.08%   77.05%   -0.03%     
==========================================
  Files          63       63              
  Lines        5729     5736       +7     
  Branches      904      907       +3     
==========================================
+ Hits         4416     4420       +4     
- Misses       1016     1017       +1     
- Partials      297      299       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d299e...2fff248. Read the comment docs.