Skip to content

adding iterop37.cs to Python.Runtime.csproj and removing old TODO com… #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2018
Merged

adding iterop37.cs to Python.Runtime.csproj and removing old TODO com… #759

merged 2 commits into from
Nov 1, 2018

Conversation

paulie4
Copy link
Contributor

@paulie4 paulie4 commented Nov 1, 2018

…ment, see #609, #720, and #609 (comment)

What does this implement/fix? Explain your changes.

iterop37.cs was missing from Python.Runtime.csproj

Does this close any currently open issues?

no, #609 and #720 were already closed, although, I don't know how #720 closed without this change...

Any other comments?

NOTE: to be able to build a usable clr.pyd using Visual Studio 2017, we had to run the following:

mklink /j "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\bin" "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.15.26726\bin\Hostx86\x86"

This is because we got the following error message in the build's output (even though the project looks like it built correctly), i.e. since the UnmanagedExports package seems to be looking for lib.exe in the wrong place for VS2017, we put the files where it was expecting to find them:

2>RGieseckeDllExport:
2>  Cannot find lib.exe in 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\\..\..\VC\bin'.
2>  Found method: clrModule..method public hidebysig static void  'initclr'() cil managed
2>  	exporting as initclr and index 0

@Jeff17Robbins Jeff17Robbins mentioned this pull request Nov 1, 2018
Closed
@den-run-ai
Copy link
Contributor

@paulie4 I don't see the same issue in latest VS 2017 Enterprise (15.8.5) .

But still we need to transition from unmanaged exports to a friendly fork dllexport:

#366

It builds fine using setup.py too.

@codecov
Copy link

codecov bot commented Nov 1, 2018 •
edited
Loading

Codecov Report

Merging #759 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage      77%   77.06%   +0.05%     
==========================================
  Files          63       63              
  Lines        5741     5777      +36     
  Branches      907      907              
==========================================
+ Hits         4421     4452      +31     
- Misses       1021     1026       +5     
  Partials      299      299
Flag Coverage Δ
#setup_linux 69.42% <ø> (+0.87%) ⬆️
#setup_windows 76.28% <ø> (+0.07%) ⬆️
Impacted Files Coverage Δ
src/runtime/runtime.cs 88.41% <ø> (ø) ⬆️
setup.py 86.2% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5134cbf...3b5e34f. Read the comment docs.

@den-run-ai den-run-ai merged commit 3e4ebac into pythonnet:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulie4 @den-run-ai @filmor