-
Notifications
You must be signed in to change notification settings - Fork 747
Make finalizer use a task #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make finalizer use a task #852
Conversation
- The callback set by `Runtime.Py_AddPendingCall()` was not being triggered in some cases in a multithreading environment. Replacing it with a `Task`
Great, thanks for your continuous efforts to backport fixes, it's highly appreciated. I'll look into merging this before the 2.4 release :) |
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
- Coverage 76.88% 65.3% -11.58%
==========================================
Files 64 1 -63
Lines 5935 294 -5641
Branches 976 0 -976
==========================================
- Hits 4563 192 -4371
+ Misses 1041 102 -939
+ Partials 331 0 -331
Continue to review full report at Codecov.
|
The Linux build seems to be fine apart from an unrelated error (happens on master as well). On Windows, however, for some reason this seems to stall, the builds time out during the unit tests. |
It trips up the |
If I remove the GIL call from |
Great, this looks a lot better, thank you very much :) |
@Martin-Molinero Using |
Runtime.Py_AddPendingCall()
was not beingtriggered in some cases in a multithreaded environment. Replacing it
with a
Task
Changes cherry-picked from Fix memory leak finalizer QuantConnect/pythonnet#29
After

Before
