Skip to content

Fix deadlock when shuting down #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2019
Merged

Fix deadlock when shuting down #30

merged 1 commit into from
May 29, 2019

Conversation

Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented May 29, 2019 •
edited
Loading

Cherry-picking last commit from PR pythonnet#852 .

Tested executing https://github.com/QuantConnect/Lean Python unit and regression tests and PythonNet unit tests [multiple times].

@jaredbroad
Copy link
Member

Please see if you can pin the threads used to 1 core to confirm low processor environments

@Martin-Molinero
Copy link
Member Author

Please see if you can pin the threads used to 1 core to confirm low processor environments

The deadlock was reproductible with the python Net unit tests pythonnet#852 (comment) in windows, caused by the using (Py.GIL()) statement

@jaredbroad jaredbroad merged commit de514d8 into QuantConnect:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martin-Molinero @jaredbroad