Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my local code I ran into a issue with default arguments. The code in the methodbinder.bind check if the arguments given is less than the arguments needed. If it is true check if there are any default arguments if so pull the default values.
The one exception is the indexer where setter is mapped to the arguments are passed along with the value. An example T[k1, k2] = v would be passed down as a tuple like (k1,k2,v). I had to check for the default arguments in the mp_ass_subscript method before calling the SetItem.
I've included simple unit tests that tests the default argument for method calls and indexers.