Skip to content

Generate NuGet package during build #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Conversation

inna-w
Copy link
Contributor

@inna-w inna-w commented May 30, 2019

What does this implement/fix? Explain your changes.

Automatically generate NuGet package during appveyor and local builds.

Does this close any currently open issues?

#165
#568

Also all bugs related to x86/x64 incorrect Python.Runtime.dll reference selection will be eliminated by providing separate package for each platform.

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@inna-w inna-w mentioned this pull request May 30, 2019
@HarelM HarelM mentioned this pull request Jun 3, 2019
Copy link
Member

@filmor filmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for filling the gaps!

<PackageLicenseUrl>https://github.com/pythonnet/pythonnet/blob/master/LICENSE</PackageLicenseUrl>
<RepositoryUrl>https://github.com/pythonnet/pythonnet</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<PackageReleaseNotes>https://github.com/pythonnet/pythonnet/releases/tag/v2.4.0</PackageReleaseNotes>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment this line for master, I'll activate it as part of the release process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@inna-w
Copy link
Contributor Author

inna-w commented Jun 3, 2019

Great, thanks for filling the gaps!

You'r welcome!

@filmor filmor merged commit 0d6194d into pythonnet:master Jun 3, 2019
@inna-w inna-w deleted the nuget branch June 4, 2019 10:27
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 18, 2020
*  Generate NuGet package during build
* Comment out PackageReleaseNotes field
* Update CHANGELOG and AUTHORS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants