Get the correct library loading functions at runtime #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmsu
reviewed
Jun 25, 2019
lostmsu
reviewed
Jun 25, 2019
lostmsu
reviewed
Jun 25, 2019
lostmsu
reviewed
Jun 25, 2019
lostmsu
reviewed
Jun 25, 2019
lostmsu
reviewed
Jun 25, 2019
lostmsu
reviewed
Jun 25, 2019
lostmsu
reviewed
Jun 25, 2019
|
Done with a review pass. |
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
=========================================
- Coverage 76.94% 76.2% -0.75%
=========================================
Files 64 65 +1
Lines 5939 6006 +67
Branches 974 985 +11
=========================================
+ Hits 4570 4577 +7
- Misses 1042 1099 +57
- Partials 327 330 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Moves the library loader to three separate classes that contain implementations for Darwin, Linux and Windows s.t. they can be initialized at runtime.
Does this close any currently open issues?
Nope, but it brings us further towards a single build.