You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does this implement/fix? Explain your changes.
I upgraded from 2.3.0 to 2.4.0 today, which seems to include the addition of a wheel import in the setup.py file. I am trying to install my own package that includes pythonnet on a machine that does not typically have wheel installed, therefore, I have to include wheel in my install_requires file. The line looks like this, note that I have put wheel first to install it before pythonnet:
Unfortunately, this still fails due to pip collecting all the packages first, which calls python setup.py egg_info for pythonnet, before wheel is installed (which occurs after all package collection is complete):
Collecting wheel (from mypackage)
Downloading pythonnet-2.4.0 (1.8MB)
100% \|████████████████████████████████\| 1.9MB 45.9MB/s
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-fvrk22zh/pythonnet/setup.py", line 18, in
from wheel import bdist_wheel
ModuleNotFoundError: No module named 'wheel'
To resolve this, I put the wheel import inside of a try/except, so that it doesn't fail while collecting the package, and would only fail if I tried to call bdist_wheel if I didn't have wheel installed.
Here's an example of another setup.py file that also try/excepts around the import of wheel when setting up the cmdclass dictionary.
And a blog post that describes a similar try/except pattern near the bottom.
...
Does this close any currently open issues?
No
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Isn't the requirements.txt just for development/deployment purposes? If I install it via pypi it doesn't make use of requirements.txt, so it doesn't seem like dropping the filter would resolve the issue?
Yeah, I got a bit confused because I stumbled over this recently when testing something on a Linux machine where wheel wasn't installed by pip from the requirements file.
Anyways, thank you very much for your contribution :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
I upgraded from
2.3.0to2.4.0today, which seems to include the addition of awheelimport in thesetup.pyfile. I am trying to install my own package that includespythonneton a machine that does not typically havewheelinstalled, therefore, I have to includewheelin myinstall_requiresfile. The line looks like this, note that I have putwheelfirst to install it beforepythonnet:Unfortunately, this still fails due to pip collecting all the packages first, which calls
python setup.py egg_infoforpythonnet, beforewheelis installed (which occurs after all package collection is complete):To resolve this, I put the
wheelimport inside of a try/except, so that it doesn't fail while collecting the package, and would only fail if I tried to callbdist_wheelif I didn't havewheelinstalled.Here's an example of another
setup.pyfile that also try/excepts around the import ofwheelwhen setting up thecmdclassdictionary.And a blog post that describes a similar try/except pattern near the bottom.
...
Does this close any currently open issues?
No
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG