-
Notifications
You must be signed in to change notification settings - Fork 747
Removes imports deprecated in Python3 #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@filmor Any idea why the build is broken? |
The Appveyor build just timed out for one part, I triggered it again and it seems to work fine now. The Travis build looks a bit trickier, the Mono version pulled in seems to be broken... |
Meh, the travis error is broken. The symbol it is missing is |
How can the build just break? Were there changes made? |
The mono version is not pinned right now, so since the 18th we pull in mono 6. I'll see whether I can lock us to 5.20 for now. |
Good spot, thank you
… On 1 Aug 2019, at 09:05, Benedikt Reinartz ***@***.***> wrote:
The mono version is not pinned right now, so since the 18th we pull in mono 6. I'll see whether I can lock us to 5.20 for now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
==========================================
+ Coverage 74.48% 76.25% +1.76%
==========================================
Files 62 65 +3
Lines 5902 6030 +128
Branches 967 990 +23
==========================================
+ Hits 4396 4598 +202
+ Misses 1153 1099 -54
+ Partials 353 333 -20
Continue to review full report at Codecov.
|
@filmor Can be merged? |
Yeah, looks good to me. @lostmsu Be aware of this one if you are looking into switching to delegates. |
What does this implement/fix? Explain your changes.
A small number of existing imports are deprecated in Python3.
This removes them or compiles them out.
Does this close any currently open issues?
Fixes #924
...
Any other comments?
N/A
Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG