Feature/named arg support #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmor
requested changes
Sep 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 1 1
Lines 301 301
=======================================
Hits 261 261
Misses 40 40
Continue to review full report at Codecov.
|
filmor
approved these changes
Sep 12, 2019
|
Great, thanks :) I'm not sure whether this DLL runs completely on .NET 4.0 anyway, we're going to require at least 4.7.2 in the future for .NET Standard compatibility. Since you left a comment on the respective line, we can shorten this later, though, so that's completely fine. |
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Dec 19, 2019
* Add support for named arguments (pythonnet#849) * Remove kwarg check since it breaks the python-derived CLR class use-case * Add named parameter test cases * Update changelog and authors * Add default params tests
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 18, 2020
* Add support for named arguments (pythonnet#849) * Remove kwarg check since it breaks the python-derived CLR class use-case * Add named parameter test cases * Update changelog and authors * Add default params tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Adds support for kwarg/named arguments when calling .NET methods from python
...
Does this close any currently open issues?
Yes, #849
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG