Improve method binding #974
Conversation
change enumerable method to non-static add tuple test for ienumerable
|
allow_threads in methodbinder.cs Invoke is true which is causing the memory corruption. If I set it to false there is no corruption so I need to look into why. This looks like it may be new code |
src/runtime/converter.cs
Outdated
| Action action = () => { | ||
| PyObject py_action = new PyObject(value); | ||
| var py_args = new PyObject[0]; | ||
| var py_result = py_action.Invoke(py_args); | ||
|
|
||
| //Discard the result since this is being converted to an Action | ||
| py_result.Dispose(); | ||
| py_action.Dispose(); | ||
| }; |
There was a problem hiding this comment.
The object pointed to by value can be collected between the construction of this action, and the moment it is invoked. It would lead to a memory corruption.
There was a problem hiding this comment.
I had forgotten to push the latest change set, please check again
|
Not suggesting this readonly implicit conversion, what if I want to use like this void AddElem(IList<int> lst)
{
lst.add(10);
}def func():
lst = [1, 2, 3]
AddElem(lst)
# I want [1,2,3,10] actuallyI suggest implement some subclasses from List<> so you can track the changes of the collection and apply them to the Python's list |
|
@amos402 see the latest changes. I'm dealing with some crash/exception in native code but I think I'm going in the direction that you are proposing. |
|
@lostmsu since we last spoke I looked into codec and it looks like string encoding, so I'm not sure how it could apply to method binding. What is your preferred way to support non-automatic conversions for me to consider/try? |
| Runtime.XIncref(iterObject); | ||
| } | ||
| ~IterableWrapper() { | ||
| Runtime.XDecref(iterObject); |
There was a problem hiding this comment.
You can't use XDecref directly in destructor, see Runtime.PyObject's destructor, you can just refer a PyObject, it can let you have no need concern about about the release.
|
Opened #1022 for my take on generic approach. |
What does this implement/fix? Explain your changes.
Two method binding changes:
Support passing lists/tuples to methods which take IEnumerable, ICollection, IList
Support passing functions to methods which take Action, Func, Task
Does this close any currently open issues?
Not that I am aware of.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG