Skip to content

some review changes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2019
Merged

some review changes #2

merged 1 commit into from
Mar 30, 2019

Conversation

digitronik
Copy link
Member

Signed-off-by: Nikhil Dhandre ndhandre@redhat.com

chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
Copy link
Contributor

@chkumar246 chkumar246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making changes, It is really needed.

bhavin192
bhavin192 requested changes Mar 30, 2019
View reviewed changes
@digitronik digitronik added the Doc Documentation label Mar 30, 2019
@digitronik
Copy link
Member Author

@bhavin192 @chkumar246 I added suggested changes have a glance on changes.

chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
bhavin192
bhavin192 reviewed Mar 30, 2019
View reviewed changes
chkumar246
chkumar246 reviewed Mar 30, 2019
View reviewed changes
Copy link
Contributor

@chkumar246 chkumar246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, Rest looks fine.

chkumar246
chkumar246 approved these changes Mar 30, 2019
View reviewed changes
@digitronik
some review changes
3277ebf 
Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>

changes

Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
Signed-off-by: Nikhil Dhandre <nik.digitronik@live.com>
@bhavin192 bhavin192 merged commit d92d323 into pythonpune:master Mar 30, 2019
@bhavin192
Copy link
Contributor

@digitronik thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavin192 bhavin192 bhavin192 approved these changes

@chkumar246 chkumar246 chkumar246 approved these changes

Assignees
No one assigned
Labels
Doc Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@digitronik @bhavin192 @chkumar246