[pytree] support PyStructSequence types for Python pytree #113258
+110
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113258
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 1fa6a44 with merge base 3e5e094 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 8, 2023
[ghstack-poisoned]
cc zou3519 [ghstack-poisoned]
XuehaiPan
commented
Nov 8, 2023
XuehaiPan
commented
Nov 8, 2023
cc zou3519 [ghstack-poisoned]
XuehaiPan
commented
Nov 8, 2023
|
I don't really have any context for the work here; @zou3519 are you taking care of it? |
@ezyang The context is to make Python pytree and C++ pytree utilities provide unified APIs. This would make users switching between these two implementations much easier.
I figured out why the Dynamo tests failed and updated the PR. See my comment in #113258 (comment) and #113258 (comment). Sorry for the pin noise @ezyang. |
Yeah I got it |
cc zou3519 [ghstack-poisoned]
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 28, 2025
ghstack-source-id: d94a116 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 31, 2025
ghstack-source-id: f148b5b Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 6, 2025
ghstack-source-id: 40edb5c Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 18, 2025
ghstack-source-id: f495659 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 27, 2025
ghstack-source-id: 16d2580 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 28, 2025
ghstack-source-id: 7993ea5 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 3, 2025
ghstack-source-id: e4e1733 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 9, 2025
ghstack-source-id: 9e17a37 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 25, 2025
ghstack-source-id: fb07f15 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 31, 2025
ghstack-source-id: 6e355d6 Pull Request resolved: pytorch#113258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
treespec_{leaf,tuple,dict}functions for args_spec modification #138214cc @zou3519