[dynamo, 3.12] xfail refleaking tests due to buggy getattr_static #125062
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125062
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 14f1559 with merge base 80046c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…_static" For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
test/dynamo/test_misc.py
Outdated
| @@ -10167,14 +10172,14 @@ def __init__(self): | |||
| self.fc_ref = fc | |||
|
|
|||
| def forward(self, x): | |||
| return fc(x[0]) | |||
| return self.fc_ref(x[0]) | |||
|
|
|||
| # return fc to keep it alive in _test_compile_model_free | |||
| return Mod(), (torch.randn(100, 100), fc) | |||
There was a problem hiding this comment.
Can you check if returning 'fc' here works correctly for '_test_compile_model_free'. The call to 'model_input_ptr' returns a tuple of 3 elements. But the code expects mod and inp. It works somehow without failing today, but causes failure for my stack.
There was a problem hiding this comment.
In 3.12 the layer leaks due to getattr_static if we call self.fc_ref but not fc. I think I originally intended to use self.fc_ref (otherwise, why would I define it?).
The return of model_inp_ctr is a little tricky but it returns 2 things - the second returned item is a tuple of input and layer, but the forward function only uses the input.
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
…_static" For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
…_static" For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: For tracking pytorch/pytorch#124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013. X-link: pytorch/pytorch#125062 Approved by: https://github.com/anijain2305, https://github.com/jansel Reviewed By: kit1980 Differential Revision: D56801860 Pulled By: williamwen42 fbshipit-source-id: 16b38ce7f1b8cabe2fcdd660fc8a2fabdda04aca
…torch#125062) For tracking pytorch#124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013. Pull Request resolved: pytorch#125062 Approved by: https://github.com/anijain2305, https://github.com/jansel
Stack from ghstack (oldest at bottom):
For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames