Skip to content

Remove deprecated torch/csrc/jit/codegen/cuda #131296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated torch/csrc/jit/codegen/cuda #131296

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jul 21, 2024 •
edited
Loading

Remove deprecated csrc/jit/codegen/cuda. The code has been deprecated for 2 year or more. Even though there may still be usage, it is worth breaking backward compatibility.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131296

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 481d615 with merge base 334b38c (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jul 21, 2024
@cyyever cyyever force-pushed the remove_deprecated branch 5 times, most recently from 4fc2665 to c8a1aee Compare July 22, 2024 07:05
@cyyever cyyever force-pushed the remove_deprecated branch 2 times, most recently from b96725b to 76c2a28 Compare July 22, 2024 10:00
@cyyever cyyever requested a review from albanD July 22, 2024 14:44
@cyyever cyyever added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category topic: deprecation topic category better-engineering Relatively self-contained tasks for better engineering contributors labels Jul 22, 2024
albanD
albanD reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a detailed PR description with more details on the "why" would be helpful!

@cyyever cyyever added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jul 23, 2024
@cyyever cyyever requested a review from albanD July 23, 2024 01:58
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 23, 2024
@cyyever cyyever requested a review from ezyang July 26, 2024 10:42
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 28, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased remove_deprecated onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout remove_deprecated && git pull --rebase)

@cyyever cyyever marked this pull request as draft September 15, 2024 06:16
@github-actions github-actions bot added the Stale label Nov 14, 2024
@cyyever cyyever removed the Stale label Nov 14, 2024
@github-actions github-actions bot added the Stale label Jan 13, 2025
@github-actions github-actions bot closed this Feb 12, 2025
@cyyever cyyever reopened this Jun 19, 2025
@pytorch pytorch deleted a comment from github-actions bot Jun 19, 2025
@pytorch pytorch deleted a comment from github-actions bot Jun 19, 2025
@cyyever cyyever force-pushed the remove_deprecated branch from b3a7a6e to f2a2058 Compare June 19, 2025 23:42
@cyyever cyyever marked this pull request as ready for review June 19, 2025 23:44
@cyyever cyyever requested a review from malfet June 19, 2025 23:45
@github-actions github-actions bot closed this Jul 20, 2025
@cyyever cyyever reopened this Jul 24, 2025
@cyyever cyyever force-pushed the remove_deprecated branch from f2a2058 to d3422f1 Compare July 24, 2025 11:52
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 24, 2025

@albanD Is it a good time to consider it?

@cyyever cyyever changed the title Remove deprecated jit code Remove deprecated torch/csrc/jit/codegen/cuda Jul 24, 2025
@cyyever cyyever force-pushed the remove_deprecated branch 2 times, most recently from cadaf98 to a611bd9 Compare July 24, 2025 11:57
@albanD
Copy link
Collaborator

albanD commented Jul 28, 2025

Curious where you found use of it?
cc @mruberry in case you have an opinion on this one?

@ptrblck ptrblck requested a review from nWEIdia July 28, 2025 19:14
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 29, 2025

I can't find references of the removed APIs elsewhere.

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 11, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@cyyever @pytorchmergebot
Remove deprecated jit code
481d615 
Signed-off-by: cyy <cyyever@outlook.com>
@pytorchmergebot
Copy link
Collaborator

Successfully rebased remove_deprecated onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout remove_deprecated && git pull --rebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

@albanD albanD Awaiting requested review from albanD

@ezyang ezyang Awaiting requested review from ezyang

@malfet malfet Awaiting requested review from malfet

@nWEIdia nWEIdia Awaiting requested review from nWEIdia

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request open source release notes: jit release notes category Stale topic: deprecation topic category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyyever @pytorchmergebot @albanD @pytorchbot