-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[BE][typing] fix types in common pruning #132309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE][typing] fix types in common pruning #132309
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132309
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ccf3f02 with merge base d95756f ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
81a3937
to
614912c
Compare
linter error is pre-existing |
@pytorchbot drci |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
614912c
to
ccf3f02
Compare
@pytorchbot revert -c ghfirst -m "The new test is failing internally. See D60567756 for details"
|
@pytorchbot successfully started a revert job. Check the current status here. |
Reverting PR 132309 failedReason: PR #132309 has not been reviewed yet |
@ZainRizvi wrong pr? |
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@henrylhtsang I am sorry I am new here. I wonder whether this is the reason that my PR has been removed? I am the author of PR #130209 . I see you have mentioned my pull request 3 weeks ago. I would appriciate it if you could give me some information about this. Thank you. |
Hi @xingyunjohn1, no worries. I think I mentioned your PR by accident. My guess is your PR got overriden by #132689 |
BE task. Add typings and remove mypy errors in torch/testing/_internal/common_pruning.py