Skip to content

[BE][typing] fix types in common pruning #132309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

henrylhtsang
Copy link
Contributor

@henrylhtsang henrylhtsang commented Jul 31, 2024

BE task. Add typings and remove mypy errors in torch/testing/_internal/common_pruning.py

Copy link

pytorch-bot bot commented Jul 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132309

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ccf3f02 with merge base d95756f (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

linux-foundation-easycla bot commented Jul 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: henrylhtsang / name: henrylhtsang (ccf3f02)

@henrylhtsang henrylhtsang force-pushed the fix_types_in_common_pruning branch from 81a3937 to 614912c Compare July 31, 2024 20:31
@henrylhtsang henrylhtsang changed the title fix types in common pruning [BE][typing] fix types in common pruning Jul 31, 2024
@henrylhtsang
Copy link
Contributor Author

linter error is pre-existing

@henrylhtsang
Copy link
Contributor Author

@pytorchbot drci

@henrylhtsang henrylhtsang requested a review from YUNQIUGUO August 1, 2024 17:21
@henrylhtsang
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix_types_in_common_pruning onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_types_in_common_pruning && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the fix_types_in_common_pruning branch from 614912c to ccf3f02 Compare August 1, 2024 17:26
@ZainRizvi
Copy link
Contributor

@pytorchbot revert -c ghfirst -m "The new test is failing internally. See D60567756 for details"

    def test_store_global_crossfile_inline(self):
>       import mock_store_global_crossfile_inline
E       ModuleNotFoundError: No module named 'mock_store_global_crossfile_inline'

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

Reverting PR 132309 failed

Reason: PR #132309 has not been reviewed yet

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@henrylhtsang
Copy link
Contributor Author

@ZainRizvi wrong pr?

@henrylhtsang
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 1, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@henrylhtsang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xingyunjohn1
Copy link
Contributor

@henrylhtsang I am sorry I am new here. I wonder whether this is the reason that my PR has been removed? I am the author of PR #130209 . I see you have mentioned my pull request 3 weeks ago. I would appriciate it if you could give me some information about this. Thank you.

@henrylhtsang
Copy link
Contributor Author

@henrylhtsang I am sorry I am new here. I wonder whether this is the reason that my PR has been removed? I am the author of PR #130209 . I see you have mentioned my pull request 3 weeks ago. I would appriciate it if you could give me some information about this. Thank you.

Hi @xingyunjohn1, no worries. I think I mentioned your PR by accident. My guess is your PR got overriden by #132689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants