Skip to content

[MPS] Add regression test for memory leak in nn.Linear #132355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] Add regression test for memory leak in nn.Linear #132355

wants to merge 1 commit into from

Conversation

hvaara
Copy link
Contributor

@hvaara hvaara commented Aug 1, 2024 •
edited
Loading

Regression test for

Questions to reviewer:

  • Should this be handled differently?
  • If this is run in quick succession (by empirical evidence <10 seconds apart) in the same process this test will be flaky. Is this likely to happen?

@hvaara hvaara requested review from kulinseth and malfet as code owners August 1, 2024 00:02
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132355

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 687ffdf with merge base 5406e46 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 1, 2024
@hvaara
Copy link
Contributor Author

hvaara commented Aug 1, 2024

@pytorchbot label "ciflow/mps"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 1, 2024

Can't add following labels to PR: ciflow/mps. Please ping one of the reviewers for help.

@qqaatw qqaatw added the ciflow/mps Run MPS tests (subset of trunk) label Aug 1, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 1, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/mps Run MPS tests (subset of trunk) label Aug 1, 2024
@qqaatw qqaatw added the ciflow/mps Run MPS tests (subset of trunk) label Aug 1, 2024
This was referenced Aug 1, 2024
Closed
Open
Closed
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Oct 4, 2024
@github-actions github-actions bot closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) open source Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hvaara @soulitzer @pytorchbot @qqaatw