Avoid args being parsed when common_utils imported #134592

nicholasw-gc · 2024-08-27T17:01:25Z

Change the parsing of args using argparse to only occur a file explicitly calls run_tests. This means that other modules importing common_utils can use argparse without inteference
Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run.
Ensure all files which should call run_tests do call run_tests.
Raise a RuntimeError on tests which have been disabled (not run)
Remove any remaining uses of "unittest.main()""

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @XilunWu @ColinPeppler @desertfire

pytorch-bot · 2024-08-27T17:01:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134592

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 56 New Failures, 2 Unrelated Failures

As of commit 2c6bb82 with merge base 0431d47 ():

NEW FAILURES - The following jobs have failed:

inductor / cuda12.4-py3.10-gcc9-sm86 / build (gh)
The process '/usr/bin/git' failed with exit code 1
inductor / linux-jammy-cpu-py3.9-gcc11-inductor / build (gh)
The process '/usr/bin/git' failed with exit code 1
inductor / unit-test / cuda12.4-py3.10-gcc9-sm86 / build (gh)
The process '/usr/bin/git' failed with exit code 1
inductor / unit-test / cuda12.4-py3.12-gcc9-sm86 / build (gh)
The process '/usr/bin/git' failed with exit code 1
inductor / unit-test / cuda12.4-py3.13-gcc9-sm86 / build (gh)
The process '/usr/bin/git' failed with exit code 1
inductor / unit-test / linux-jammy-cpu-py3.12-gcc11-inductor-halide / build (gh)
The process '/usr/bin/git' failed with exit code 1
inductor / unit-test / linux-jammy-cpu-py3.12-gcc11-inductor-triton-cpu / build (gh)
The process '/usr/bin/git' failed with exit code 1
inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / build (gh)
The process '/usr/bin/git' failed with exit code 1
inductor-rocm / rocm6.2-py3.10-inductor / build (gh)
The process '/usr/bin/git' failed with exit code 1
Lint / lintrunner-noclang / linux-job (gh)
>>> Lint for test/quantization/pt2e/test_x86inductor_quantizer.py:
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh)
distributed/pipelining/test_schedule_multiproc.py::ScheduleTest::test_forward_only_ScheduleClass0
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh)
distributed/pipelining/test_stage.py::StageTest::test_custom_dw_errors
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 3, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh)
distributed/test_c10d_ops_nccl.py::ProcessGroupNCCLOpTest::test_allgather_base_basics
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 1, 5, lf.linux.4xlarge.nvidia.gpu) (gh)
lazy/test_meta_kernel.py::TestMetaKernel::test_addmm_invalid_dtype
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 2, 5, lf.linux.4xlarge.nvidia.gpu) (gh)
RuntimeError: test_quantization 1/6 failed!
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 3, 5, lf.linux.4xlarge.nvidia.gpu) (gh)
RuntimeError: test_quantization 2/6 failed!
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 4, 5, lf.linux.4xlarge.nvidia.gpu) (gh)
RuntimeError: test_quantization 3/6 failed!
pull / linux-focal-cuda12.4-py3.10-gcc9 / test (default, 5, 5, lf.linux.4xlarge.nvidia.gpu) (gh)
RuntimeError: test_quantization 4/6 failed!
pull / linux-focal-cuda12.4-py3.10-gcc9-sm89 / test (default, 1, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
lazy/test_meta_kernel.py::TestMetaKernel::test_addmm_invalid_dtype
pull / linux-focal-cuda12.4-py3.10-gcc9-sm89 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
RuntimeError: test_quantization 1/3 failed!
pull / linux-focal-cuda12.4-py3.10-gcc9-sm89 / test (default, 3, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
RuntimeError: test_quantization 2/3 failed!
pull / linux-focal-cuda12.4-py3.10-gcc9-sm89 / test (default, 4, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
RuntimeError: test_quantization 3/3 failed!
pull / linux-focal-cuda12.4-py3.10-gcc9-sm89 / test (default, 5, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh)
test_ao_sparsity.py::TestQlinearPackedParams::test_qlinear_packed_params_fbgemm
pull / linux-focal-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge) (gh)
test_reference_eager_zero__xla_int64
pull / linux-focal-py3.13-clang10 / test (crossref, 1, 2, lf.linux.2xlarge) (gh)
lazy/test_meta_kernel.py::TestMetaKernel::test_addmm_invalid_dtype
pull / linux-focal-py3.13-clang10 / test (crossref, 2, 2, lf.linux.2xlarge) (gh)
RuntimeError: test_quantization 1/4 failed!
pull / linux-focal-py3.13-clang10 / test (default, 1, 5, lf.linux.4xlarge) (gh)
lazy/test_meta_kernel.py::TestMetaKernel::test_addmm_invalid_dtype
pull / linux-focal-py3.13-clang10 / test (default, 2, 5, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 1/3 failed!
pull / linux-focal-py3.13-clang10 / test (default, 3, 5, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 2/3 failed!
pull / linux-focal-py3.13-clang10 / test (default, 4, 5, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 3/3 failed!
pull / linux-focal-py3.13-clang10 / test (default, 5, 5, lf.linux.4xlarge) (gh)
test_ao_sparsity.py::TestQlinearPackedParams::test_qlinear_packed_params_fbgemm
pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge) (gh)
RuntimeError: cpp/Dict_test 1/1 failed!
pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 3, 3, lf.linux.2xlarge) (gh)
RuntimeError: test_quantization 1/5 failed!
pull / linux-focal-py3.9-clang10 / test (crossref, 1, 2, lf.linux.2xlarge) (gh)
lazy/test_meta_kernel.py::TestMetaKernel::test_addmm_invalid_dtype
pull / linux-focal-py3.9-clang10 / test (crossref, 2, 2, lf.linux.2xlarge) (gh)
RuntimeError: test_quantization 1/4 failed!
pull / linux-focal-py3.9-clang10 / test (default, 1, 5, lf.linux.4xlarge) (gh)
lazy/test_meta_kernel.py::TestMetaKernel::test_addmm_invalid_dtype
pull / linux-focal-py3.9-clang10 / test (default, 2, 5, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 1/3 failed!
pull / linux-focal-py3.9-clang10 / test (default, 3, 5, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 2/3 failed!
pull / linux-focal-py3.9-clang10 / test (default, 4, 5, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 3/3 failed!
pull / linux-focal-py3.9-clang10 / test (default, 5, 5, lf.linux.4xlarge) (gh)
test_ao_sparsity.py::TestQlinearPackedParams::test_qlinear_packed_params_fbgemm
pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge) (gh)
RuntimeError: cpp/Dict_test 1/1 failed!
pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 3, 3, lf.linux.2xlarge) (gh)
RuntimeError: test_quantization 1/5 failed!
pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, lf.linux.4xlarge) (gh)
lazy/test_meta_kernel.py::TestMetaKernel::test_addmm_invalid_dtype
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 1/9 failed!
pull / linux-jammy-py3.10-clang15-asan / test (default, 3, 6, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 2/9 failed!
pull / linux-jammy-py3.10-clang15-asan / test (default, 4, 6, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 3/9 failed!
pull / linux-jammy-py3.10-clang15-asan / test (default, 5, 6, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 4/9 failed!
pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, lf.linux.4xlarge) (gh)
RuntimeError: test_quantization 5/9 failed!
pull / linux-jammy-py3.9-gcc11 / test (default, 1, 5, lf.linux.2xlarge) (gh)
lazy/test_meta_kernel.py::TestMetaKernel::test_addmm_invalid_dtype
pull / linux-jammy-py3.9-gcc11 / test (default, 2, 5, lf.linux.2xlarge) (gh)
RuntimeError: test_quantization 1/3 failed!
pull / linux-jammy-py3.9-gcc11 / test (default, 3, 5, lf.linux.2xlarge) (gh)
RuntimeError: test_quantization 2/3 failed!
pull / linux-jammy-py3.9-gcc11 / test (default, 4, 5, lf.linux.2xlarge) (gh)
RuntimeError: test_quantization 3/3 failed!
pull / linux-jammy-py3.9-gcc11 / test (default, 5, 5, lf.linux.2xlarge) (gh)
test_ao_sparsity.py::TestQlinearPackedParams::test_qlinear_packed_params_fbgemm
pull / linux-jammy-py3.9-gcc11 / test (distributed, 1, 2, lf.linux.2xlarge) (gh)
distributed/tensor/parallel/test_tp_style.py::TensorParallelStyleTest::test_sequence_parallel_style
pull / linux-jammy-py3.9-gcc11 / test (distributed, 2, 2, lf.linux.2xlarge) (gh)
distributed/_tensor/test_dtensor.py::DTensorMeshTest::test_implicit_replication_for_foreach_ops
pull / linux-jammy-py3.9-gcc11 / test (jit_legacy, 1, 1, lf.linux.2xlarge) (gh)
test_jit_legacy.py::TestJit::test_dropout_func_requires_grad

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 2, 3, lf.linux.2xlarge) (gh) (disabled by #144920 but the issue was closed recently and a rebase is needed to make it pass)
test_python_dispatch.py::TestPythonRegistration::test_returning_symint
pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 2, 3, lf.linux.2xlarge) (gh) (disabled by #144920 but the issue was closed recently and a rebase is needed to make it pass)
test_python_dispatch.py::TestPythonRegistration::test_returning_symint

This comment was automatically generated by Dr. CI and updates every 15 minutes.

nicholasw-gc · 2024-09-06T12:12:12Z

@jerryzh168 @HDCharles pinging as it's been 5 working days though I recognise it's close to holiday season and the diff is huge. Would be good allow workflow approval to run more tests over weekend.

nicholasw-gc · 2024-10-08T14:26:16Z

@jerryzh168 @HDCharles pinging again: if this is good in principle, I can resolve conflicts.

clee2000 · 2024-10-08T16:01:10Z

test/distributed/pipelining/test_schedule_multiproc.py

@@ -821,3 +822,4 @@ def dw_runner():
            nprocs=world_size,
            args=(world_size, rdvz_file),
        )
+    run_tests()


I'm not sure this should be here or in the other distributed files, cc @wconstab

Other than that I think it looks ok, but I think CI will be the final judge

My only goal here was consistency. I make 127 instances of run_tests() in test/distributed but happy to erase them. Or would it just be the pipelining subdir where there are 6?. @wconstab

What do you reckon for this?

nicholasw-gc · 2024-10-22T14:42:30Z

@jerryzh168 @HDCharles @wconstab Are you able to review?

nicholasw-gc · 2024-10-23T13:41:22Z

@jerryzh168 @HDCharles @wconstab Are you able to review?

@jerryzh168 pinging as it looks like you're reviewing PRs today?

jerryzh168 · 2024-10-23T19:43:12Z

test/ao/sparsity/test_qlinear_packed_params.py

@@ -286,3 +286,10 @@ def packed_params_data_with_int32_indices(data_as_state_and_weight_bias):
            packed_params_data_with_int32_indices(packed_params_data_2a),
            packed_params_data_with_int32_indices(packed_params_data_2b),
        )
+
+
+if __name__ == "__main__":


why not enable this?

Enabled now, will see what happens!

jerryzh168

thanks! quantization and sparsity changes LGTM

nicholasw-gc · 2024-11-20T10:35:31Z

@jerryzh168 @HDCharles @wconstab
Please can I get workflows approved and review. Many thanks!

- Change the parsing of args using argparse to only occur when a file explicitly calls run_tests. This means that other modules importing common_utils can use argparse without inteference - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Ensure all files which should call run_tests do call run_tests. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" - Enable "test_qlinear_packed_params.py"

nicholasw-gc · 2025-01-03T12:25:49Z

@jerryzh168 @HDCharles @wconstab
Happy New Year! I have rebased onto the latest main. Any chance of a quick review as it will likely need rebasing before long? Many thanks!

jerryzh168 · 2025-01-03T17:48:42Z

changes to quantization test files LGTM, please ask @clee2000 and @wconstab for reviews of the other files

github-actions · 2025-03-04T20:35:01Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. In fx tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()""

This is the first PR of a series in an attempt to re-submit pytorch#134592 as smaller PRs.

This PR is part of a series attempting to re-submit #134592 as smaller PRs. Add missing `if __name__ == "__main__":` guards to some tests. Pull Request resolved: #154716 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit #134592 as smaller PRs. In fx tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" Pull Request resolved: #154715 Approved by: https://github.com/Skylion007

@wconstab

This is the first PR of a series in an attempt to re-submit #134592 as smaller PRs. In distributed tests: - Ensure all files which should call run_tests do call run_tests. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" Cc @wconstab @clee2000 Pull Request resolved: #154628 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit #134592 as smaller PRs. In jit tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) Pull Request resolved: #154725 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. Add missing `if __name__ == "__main__":` guards to some tests. Pull Request resolved: pytorch#154716 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. In fx tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" Pull Request resolved: pytorch#154715 Approved by: https://github.com/Skylion007

@wconstab

This is the first PR of a series in an attempt to re-submit pytorch#134592 as smaller PRs. In distributed tests: - Ensure all files which should call run_tests do call run_tests. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" Cc @wconstab @clee2000 Pull Request resolved: pytorch#154628 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. In jit tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) Pull Request resolved: pytorch#154725 Approved by: https://github.com/Skylion007

@jerryzh168

This is the first PR of a series in an attempt to get the content of #134592 merged as smaller PRs (Given that the original one was closed due to a lack of reviewers). This specific PR contains: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Update ao tests. There will be follow up PRs to update the other test suites but I don't have permissions to create branches directly on pytorch/pytorch so I can't create a stack and therefore will have to create them one at the time. Cc @jerryzh168 Pull Request resolved: #154612 Approved by: https://github.com/jcaip

This PR is part of a series attempting to re-submit #134592 as smaller PRs. In quantization tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) Pull Request resolved: #154728 Approved by: https://github.com/ezyang

@jerryzh168

This is the first PR of a series in an attempt to get the content of pytorch#134592 merged as smaller PRs (Given that the original one was closed due to a lack of reviewers). This specific PR contains: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Update ao tests. There will be follow up PRs to update the other test suites but I don't have permissions to create branches directly on pytorch/pytorch so I can't create a stack and therefore will have to create them one at the time. Cc @jerryzh168 Pull Request resolved: pytorch#154612 Approved by: https://github.com/jcaip

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. In quantization tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) Pull Request resolved: pytorch#154728 Approved by: https://github.com/ezyang

This PR is part of a series attempting to re-submit #134592 as smaller PRs. In jit tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) Pull Request resolved: #154725 Approved by: https://github.com/clee2000

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. Add missing `if __name__ == "__main__":` guards to some tests. Pull Request resolved: pytorch#154716 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. In fx tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" Pull Request resolved: pytorch#154715 Approved by: https://github.com/Skylion007

@wconstab

This is the first PR of a series in an attempt to re-submit pytorch#134592 as smaller PRs. In distributed tests: - Ensure all files which should call run_tests do call run_tests. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" Cc @wconstab @clee2000 Pull Request resolved: pytorch#154628 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. In jit tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) Pull Request resolved: pytorch#154725 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. Add missing `if __name__ == "__main__":` guards to some tests. Pull Request resolved: pytorch#154716 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. In fx tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" Pull Request resolved: pytorch#154715 Approved by: https://github.com/Skylion007

@wconstab

This is the first PR of a series in an attempt to re-submit pytorch#134592 as smaller PRs. In distributed tests: - Ensure all files which should call run_tests do call run_tests. - Raise a RuntimeError on tests which have been disabled (not run) - Remove any remaining uses of "unittest.main()"" Cc @wconstab @clee2000 Pull Request resolved: pytorch#154628 Approved by: https://github.com/Skylion007

This PR is part of a series attempting to re-submit pytorch#134592 as smaller PRs. In jit tests: - Add and use a common raise_on_run_directly method for when a user runs a test file directly which should not be run this way. Print the file which the user should have run. - Raise a RuntimeError on tests which have been disabled (not run) Pull Request resolved: pytorch#154725 Approved by: https://github.com/Skylion007

…ed. (#156703) Last PR in the series to re-submit #134592 as smaller PRs: #154612 #154628 #154715 #154716 #154725 #154728 Pull Request resolved: #156703 Approved by: https://github.com/clee2000

nicholasw-gc requested review from a team, jerryzh168 and HDCharles as code owners August 27, 2024 17:01

pytorch-bot bot added module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: quantization release notes category release notes: AO frontend labels Aug 27, 2024

pytorchbot added the open source label Aug 27, 2024

janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 30, 2024

clee2000 reviewed Oct 8, 2024

View reviewed changes

clee2000 added the ci-no-td Do not run TD on this PR label Oct 8, 2024

nicholasw-gc force-pushed the PYT-117 branch 2 times, most recently from b6becac to 49c8c3f Compare October 15, 2024 12:54

jerryzh168 reviewed Oct 23, 2024

View reviewed changes

nicholasw-gc force-pushed the PYT-117 branch from 49c8c3f to a88816a Compare October 28, 2024 15:57

nicholasw-gc force-pushed the PYT-117 branch from a88816a to 102e99e Compare November 15, 2024 14:26

nicholasw-gc requested review from jerryzh168 and clee2000 November 20, 2024 10:35

nicholasw-gc force-pushed the PYT-117 branch from 102e99e to 2c6bb82 Compare January 2, 2025 22:49

This was referenced May 30, 2025

Add __main__ guards to fx tests #154715

Closed

Add __main__ guards to tests #154716

Closed

Add __main__ guards to jit tests #154725

Closed

Add __main__ guards to quantization tests #154728

Closed

AnthonyBarbier added a commit to graphcore/pytorch-fork that referenced this pull request Jun 2, 2025

Add __main__ guards to distributed tests

7f45ba2

This is the first PR of a series in an attempt to re-submit pytorch#134592 as smaller PRs.

AnthonyBarbier mentioned this pull request Jun 24, 2025

Stop parsing command line arguments every time common_utils is imported. #156703

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid args being parsed when common_utils imported #134592

Avoid args being parsed when common_utils imported #134592

Uh oh!

nicholasw-gc commented Aug 27, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Aug 27, 2024 •

edited

Loading

Uh oh!

nicholasw-gc commented Sep 6, 2024

Uh oh!

nicholasw-gc commented Oct 8, 2024

Uh oh!

clee2000 Oct 8, 2024 •

edited

Loading

Uh oh!

nicholasw-gc Oct 11, 2024

Uh oh!

nicholasw-gc Oct 18, 2024

Uh oh!

nicholasw-gc commented Oct 22, 2024

Uh oh!

nicholasw-gc commented Oct 23, 2024

Uh oh!

jerryzh168 Oct 23, 2024

Uh oh!

nicholasw-gc Oct 28, 2024

Uh oh!

jerryzh168 left a comment

Uh oh!

nicholasw-gc commented Nov 20, 2024

Uh oh!

nicholasw-gc commented Jan 3, 2025

Uh oh!

jerryzh168 commented Jan 3, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

Uh oh!

Avoid args being parsed when common_utils imported #134592

Avoid args being parsed when common_utils imported #134592

Uh oh!

Conversation

nicholasw-gc commented Aug 27, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134592

❌ 56 New Failures, 2 Unrelated Failures

Uh oh!

nicholasw-gc commented Sep 6, 2024

Uh oh!

nicholasw-gc commented Oct 8, 2024

Uh oh!

clee2000 Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicholasw-gc Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

nicholasw-gc Oct 18, 2024

Choose a reason for hiding this comment

Uh oh!

nicholasw-gc commented Oct 22, 2024

Uh oh!

nicholasw-gc commented Oct 23, 2024

Uh oh!

jerryzh168 Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

nicholasw-gc Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

jerryzh168 left a comment

Choose a reason for hiding this comment

Uh oh!

nicholasw-gc commented Nov 20, 2024

Uh oh!

nicholasw-gc commented Jan 3, 2025

Uh oh!

jerryzh168 commented Jan 3, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

Uh oh!

nicholasw-gc commented Aug 27, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 27, 2024 •

edited

Loading

clee2000 Oct 8, 2024 •

edited

Loading