[inductor] fix the unligned variable ranges issue in fuse node #138568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138568
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 54dcda8 with merge base f4ee5a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vfdev-5
reviewed
Oct 22, 2024
aa53650 to
e4c22de
Compare
|
The new UT would fail for another fma VecN issue. Land after the fix: #138655. |
jgong5
requested changes
Oct 24, 2024
e4c22de to
c59e50c
Compare
Thanks! The failed UT triggers an issue about fma VectorizedN, which depends on the fix of #138655. The PR descriptions are updated. |
a446180 to
2a764fa
Compare
jgong5
reviewed
Oct 28, 2024
2a764fa to
25ddbf3
Compare
jgong5
requested changes
Oct 31, 2024
25ddbf3 to
05cb2a7
Compare
jgong5
approved these changes
Nov 4, 2024
05cb2a7 to
54dcda8
Compare
leslie-fang-intel
approved these changes
Nov 6, 2024
jansel
approved these changes
Nov 6, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…ch#138568) Fixes pytorch#138550. ### Description In the fusion of two nodes, one node with less variables (`node_to_recomp`) would make its variable ranges aligned with the other node (`ref_node`). In detail, `node_to_recomp` would change its variable ranges to the original ranges of `ref_node`. However, if both of the nodes have changed its ranges, i.e., the simplified variable ranges are different from its original ones, the issue comes up. ### Solution For the case where the `ref_node` also changes its variable ranges, we recompute the size and body for it, to ensure the nodes are simplified to the same size. Pull Request resolved: pytorch#138568 Approved by: https://github.com/jgong5, https://github.com/leslie-fang-intel, https://github.com/jansel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138550.
Description
In the fusion of two nodes, one node with less variables (
node_to_recomp) would make its variable ranges aligned with the other node (ref_node). In detail,node_to_recompwould change its variable ranges to the original ranges ofref_node. However, if both of the nodes have changed its ranges, i.e., the simplified variable ranges are different from its original ones, the issue comes up.Solution
For the case where the
ref_nodealso changes its variable ranges, we recompute the size and body for it, to ensure the nodes are simplified to the same size.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov