[dynamo, nested graph breaks] add nested graph break tests #144516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

williamwen42 wants to merge 30 commits into gh/williamwen42/196/base from gh/williamwen42/196/head

Member

williamwen42 commented Jan 10, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela


          add nested graph break tests

40e526d

[ghstack-poisoned]

pytorch-bot bot commented Jan 10, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144516

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7bc646b with merge base d68c323 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: dynamo labels

williamwen42 added a commit that referenced this pull request


          add nested graph break tests

cb31079

ghstack-source-id: 2e25912
Pull Request resolved: #144516

williamwen42 marked this pull request as draft

January 10, 2025 00:16

Contributor

github-actions bot commented Mar 11, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions bot added the Stale label

williamwen42 removed the Stale label


          Update on "add nested graph break tests"

04e409b

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] small fixes to resume function generation #151056

Closed

williamwen42 changed the title ~~add nested graph break tests~~ [dynamo, nested graph breaks] add nested graph break tests


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

0415dc9

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request


          add nested graph break tests

3ceaebf

ghstack-source-id: eef6717
Pull Request resolved: pytorch/pytorch#144516


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

59b736c

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] refactor codegen to minimize NULL codegen'ing #153510

Closed


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

01b5875

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

09c01a2

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

b1ab7a0

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

5a419d0

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request


          add nested graph break tests

c31d0e0

ghstack-source-id: f415878
Pull Request resolved: #144516


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

a3f4af1

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

a2d97b2

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] remove block stack graph break in output_graph #153772

Closed

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] implement new resume frame stack/locals/cell layout convention #157971

Open

williamwen42 added 2 commits

July 25, 2025 13:23


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

0438c48

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

c0470a3

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] use CALL_FUNCTION_EX when calling resume function #159281

Open

williamwen42 added a commit that referenced this pull request


          add nested graph break tests

d04f1f9

ghstack-source-id: cb40d16
Pull Request resolved: #144516

williamwen42 added the topic: not user facing label


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

a5511f8

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] support very simple nested graph breaks #159329

Open

williamwen42 added a commit that referenced this pull request


          add nested graph break tests

0daec03

ghstack-source-id: 25a00a4
Pull Request resolved: #144516


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

229b823

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request


          add nested graph break tests

1d70d98

ghstack-source-id: 6aede2f
Pull Request resolved: #144516


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

4fda372

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request


          add nested graph break tests

74096e0

ghstack-source-id: 660edce
Pull Request resolved: #144516


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

75ae11d

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 added a commit that referenced this pull request


          add nested graph break tests

753b610

ghstack-source-id: a001736
Pull Request resolved: #144516


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

aabd6aa

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] support nested graph breaks x context managers #159678

Open

williamwen42 added 3 commits

August 1, 2025 14:55


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

6c7d93b

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

5583e83

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

ec3387b

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] prevent excessive recompilations #159786

Open


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

a160091

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] support nested closures #159817

Open


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

c2addec

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 mentioned this pull request

[dynamo, nested graph breaks] clean up comments and codegen #160138

Open


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

df23d5d

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

williamwen42 marked this pull request as ready for review

August 8, 2025 01:46

williamwen42 requested review from anijain2305 and StrongerXi

August 8, 2025 23:28


          Update on "[dynamo, nested graph breaks] add nested graph break tests"

7bc646b

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor module: dynamo topic: not user facing