Allow setting attribute to NestedUserFunctionVariable #146505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146505
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1ab12fb with merge base 0dcd482 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 5, 2025
Closed
Closed
Closed
anijain2305
reviewed
Feb 5, 2025
torch/_dynamo/variables/functions.py
Outdated
| name_var: VariableTracker, | ||
| val: VariableTracker, | ||
| ): | ||
| self.setattr_values[name_var] = val |
There was a problem hiding this comment.
You will also have to update var_getattr and look for self.setattr_values.
This was referenced Mar 7, 2025
zou3519
reviewed
Mar 7, 2025
zou3519
approved these changes
Mar 20, 2025
|
Starting merge as part of PR stack under #148765 |
1 similar comment
|
Starting merge as part of PR stack under #148765 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 20, 2025
Pull Request resolved: #148765 Approved by: https://github.com/zou3519 ghstack dependencies: #146505
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#146505 Approved by: https://github.com/zou3519
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…ch#148765) Pull Request resolved: pytorch#148765 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#146505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
contextlib.suppress#147990raise ... from ...#148766StopIteration#148765cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames