Skip to content

[ONNX] Implement sym_not #147472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[ONNX] Implement sym_not #147472

wants to merge 2 commits into from

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Feb 19, 2025 •
edited
Loading

@justinchuby
Update
2407741 
[ghstack-poisoned]
This was referenced Feb 19, 2025
Closed
Open
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 19, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147472

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 7255b5b with merge base bd370c1 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@justinchuby justinchuby added module: onnx Related to torch.onnx topic: improvements topic category labels Feb 19, 2025
@justinchuby
Update
7255b5b 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Feb 19, 2025
@justinchuby
[ONNX] Implement sym_not
15bcae2 
ghstack-source-id: 7a798d5
Pull Request resolved: #147472
titaiwangms
titaiwangms approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know this works?

@cyyever
Copy link
Collaborator

cyyever commented Mar 29, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 29, 2025
@cyyever
Copy link
Collaborator

cyyever commented Mar 29, 2025

@pytorchmergebot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/justinchuby/112/orig returned non-zero exit code 1

warning: skipped previously applied commit 19b933fbd52
warning: skipped previously applied commit 3b83ea695ab
hint: use --reapply-cherry-picks to include skipped commits
hint: Disable this message with "git config set advice.skippedCherryPicks false"
Rebasing (1/2)
Auto-merging test/onnx/exporter/test_small_models_e2e.py
Auto-merging test/onnx/torchlib/ops_test_data.py
Auto-merging torch/onnx/_internal/exporter/_registration.py
Auto-merging torch/onnx/_internal/exporter/_torchlib/ops/__init__.py
CONFLICT (content): Merge conflict in torch/onnx/_internal/exporter/_torchlib/ops/__init__.py
error: could not apply f2d22461d7f... [ONNX] Migrate onnx ops decomp functions
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply f2d22461d7f... [ONNX] Migrate onnx ops decomp functions

Raised by https://github.com/pytorch/pytorch/actions/runs/14142073515

@cyyever
Copy link
Collaborator

cyyever commented Mar 29, 2025

@justinchuby It's better to rebase and perform tests

@justinchuby
Copy link
Collaborator Author

Thanks, but please kindly do not merge or alter any ONNX PRs. The onnx team needs to control the merging process.

@justinchuby justinchuby mentioned this pull request Apr 24, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Apr 25, 2025
@justinchuby @pytorchmergebot
[ONNX] Implement sym_not (#152111)
a811d33 
Implement onnx support for sym_not. Replaces #147472

Fix #136572
Pull Request resolved: #152111
Approved by: https://github.com/titaiwangms
@github-actions github-actions bot deleted the gh/justinchuby/112/head branch May 25, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justinchuby @cyyever @pytorchmergebot @titaiwangms @pytorchbot