Skip to content

[BE][pytree] rename NodeDef member to match the type annotations: *_fn -> *_func #148474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: gh/XuehaiPan/254/base
Choose a base branch
from
Open

[BE][pytree] rename NodeDef member to match the type annotations: *_fn -> *_func #148474

wants to merge 20 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Mar 4, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

This PR renames the member in NodeDef from *_fn -> *_func. The old names are aliased to the new names and will emit a FutureWarning when accessed.

cc @zou3519

@XuehaiPan
Update
dfbd510 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148474

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ebb7983 with merge base 556e2a7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

XuehaiPan added a commit that referenced this pull request Mar 4, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations
133f607 
ghstack-source-id: ebfc335
Pull Request resolved: #148474
@XuehaiPan
Update
03974bf 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Mar 4, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations
ef7c4aa 
ghstack-source-id: d5c6cc4
Pull Request resolved: #148474
@XuehaiPan XuehaiPan changed the title [BE][pytree] rename NodeDef member to match the type annotations [BE][pytree] rename NodeDef member to match the type annotations: *_fn -> *_func Mar 4, 2025
XuehaiPan added a commit that referenced this pull request Mar 4, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
36175a9 
…*_fn -> *_func`

ghstack-source-id: d5c6cc4
Pull Request resolved: #148474
@XuehaiPan XuehaiPan requested a review from zou3519 March 4, 2025 20:03
@XuehaiPan XuehaiPan mentioned this pull request Mar 4, 2025
Open
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 4, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
0a66cf0 
…*_fn -> *_func`

ghstack-source-id: d5c6cc4
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 4, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
9e03f4d 
…*_fn -> *_func`

ghstack-source-id: d5c6cc4
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
83b754d 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 12, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
008fc21 
…*_fn -> *_func`

ghstack-source-id: e43a4e5
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
715ac1d 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 13, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
f6fbb64 
…*_fn -> *_func`

ghstack-source-id: 4f6f9e1
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 13, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
edeff7c 
…*_fn -> *_func`

ghstack-source-id: 4f6f9e1
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
15cf001 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 14, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
05116cf 
…*_fn -> *_func`

ghstack-source-id: f868b48
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
8ee92ae 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Mar 31, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
82e180f 
…*_fn -> *_func`

ghstack-source-id: 2cce41e
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
39cc84f 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
6eb150d 
…*_fn -> *_func`

ghstack-source-id: 243fdd4
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 2, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
d02c05b 
…*_fn -> *_func`

ghstack-source-id: 243fdd4
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
61d3af2 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 8, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
c3cd62b 
…*_fn -> *_func`

ghstack-source-id: 685c860
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 11, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
86f2818 
…*_fn -> *_func`

ghstack-source-id: 685c860
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
3fde490 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
37c6717 
…*_fn -> *_func`

ghstack-source-id: 1f85438
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 16, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
b160202 
…*_fn -> *_func`

ghstack-source-id: 1f85438
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
b713968 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 16, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
13b6ec7 
…*_fn -> *_func`

ghstack-source-id: e9cdaeb
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
568fb71 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 28, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
aec24b5 
…*_fn -> *_func`

ghstack-source-id: 840727f
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
52ab359 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 31, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
f42b88c 
…*_fn -> *_func`

ghstack-source-id: cb20af8
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
d1772fe 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 7, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
2d97c11 
…*_fn -> *_func`

ghstack-source-id: 3ae4b62
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 9, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
3cb7957 
…*_fn -> *_func`

ghstack-source-id: 3ae4b62
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
4bbf561 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 18, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
8e30efe 
…*_fn -> *_func`

ghstack-source-id: 374ad29
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 24, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
fa14009 
…*_fn -> *_func`

ghstack-source-id: 374ad29
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 24, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
5a6db8a 
…*_fn -> *_func`

ghstack-source-id: 374ad29
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
b4efbdc 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 3, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
134746b 
…*_fn -> *_func`

ghstack-source-id: 01bab48
Pull Request resolved: pytorch#148474
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 5, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
3ff5931 
…*_fn -> *_func`

ghstack-source-id: 01bab48
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
12d5d26 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 9, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
10ad6cc 
…*_fn -> *_func`

ghstack-source-id: ba8945e
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
d81f4b6 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 25, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
7e23b90 
…*_fn -> *_func`

ghstack-source-id: 5f14bac
Pull Request resolved: pytorch#148474
@XuehaiPan
Update
ebb7983 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 8, 2025
@XuehaiPan
[BE][pytree] rename NodeDef member to match the type annotations: `…
0d62a83 
…*_fn -> *_func`

ghstack-source-id: 9564639
Pull Request resolved: pytorch#148474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees
No one assigned
Labels
module: pytree open source release notes: export topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XuehaiPan @pytorchbot