Add some CPython tests to dynamo #150466
Closed
Add some CPython tests to dynamo #150466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
This was referenced Apr 1, 2025
guilhermeleobas
added a commit
that referenced
this pull request
Apr 1, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: 33673c9 Pull Request resolved: #150466
guilhermeleobas
added a commit
that referenced
this pull request
Apr 1, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: ab3521c Pull Request resolved: #150466
guilhermeleobas
added a commit
that referenced
this pull request
Apr 1, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: 36ea1ba Pull Request resolved: #150466
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 2, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: b9c0f75 Pull Request resolved: #150466
|
Successfully rebased |
guilhermeleobas
added a commit
that referenced
this pull request
Apr 2, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: 4476bf4 Pull Request resolved: #150466
guilhermeleobas
added a commit
that referenced
this pull request
Apr 2, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: 9b59e4d Pull Request resolved: #150466
zou3519
reviewed
Apr 3, 2025
|
|
||
| key = f"{self.__class__.__name__}.{self._testMethodName}" | ||
| key = self._dynamo_test_key() |
There was a problem hiding this comment.
I would recommend splitting up this PR a little.
- all the non-cpython tests
- adding the cpython test files (this might be one-at-a-time, or in a batch). More of a question for @albanD I think
Also, separately, Alban, Do you think there's a better way for us to reuse the cpython tests instead of copy-pasting and modifying them into pytorch?
There was a problem hiding this comment.
Separating the scaffolding from the files would definitely be helpful. As this PR stands, it freezes the github UI when you look at the diff, so tricky to review :/
Also, separately, Alban, Do you think there's a better way for us to reuse the cpython tests instead of copy-pasting and modifying them into pytorch?
It depends what are the changes needed after copy-pasting?
There was a problem hiding this comment.
The changes involve fixing some imports and replacing unittest.TestCase with PyTorch's TestCase class.
guilhermeleobas
added a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Apr 3, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: 9b59e4d Pull Request resolved: pytorch#150466
guilhermeleobas
added a commit
that referenced
this pull request
Apr 3, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: e9a1207 Pull Request resolved: #150466
guilhermeleobas
added a commit
that referenced
this pull request
Apr 3, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: 7d03bd0 Pull Request resolved: #150466
guilhermeleobas
added a commit
that referenced
this pull request
Apr 4, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_exception_variations.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: 1840141 Pull Request resolved: #150466
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 7, 2025
CPython tests included: * test_baseexception.py * test_cmath.py * test_complex.py * test_contextlib.py * test_dict.py * test_exceptions.py * test_exception_variations.py * test_float.py * test_generators.py * test_generator_stop.py * test_grammar.py * test_int_literal.py * test_int.py * test_iter.py * test_list.py * test_math.py * test_ordered_dict.py * test_raise.py * test_setcomps.py * test_set.py * test_sort.py * test_string.py * test_sys.py * test_tuple.py * test_userdict.py * test_userlist.py * test_userstring.py * unittest/test_assertions.py ghstack-source-id: b3203f6 Pull Request resolved: #150466
|
Successfully rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
contextlib.suppress#147990CPython tests included:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames