[ez][dynamo] some code movement #150753
Closed
[ez][dynamo] some code movement #150753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`optimize_assert` already does the lookup for `backend` and `backend_ctx_ctor`. This simply moves the lookups within `optimize` lower so we don't end up calling these functions twice unnecessarily in the `optimize_assert` path. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150753
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f19c44e with merge base 47b494e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 7, 2025
anijain2305
approved these changes
Apr 13, 2025
jansel
approved these changes
Apr 13, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 14, 2025
Pull Request resolved: #150754 Approved by: https://github.com/anijain2305, https://github.com/jansel, https://github.com/Skylion007 ghstack dependencies: #150753
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 14, 2025
Pull Request resolved: #150755 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: #150753, #150754
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 14, 2025
Pull Request resolved: #150828 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: #150753, #150754, #150755
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 14, 2025
Pull Request resolved: #151179 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: #150753, #150754, #150755, #150828
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
`optimize_assert` already does the lookup for `backend` and `backend_ctx_ctor`. This simply moves the lookups within `optimize` lower so we don't end up calling these functions twice unnecessarily in the `optimize_assert` path. Pull Request resolved: pytorch#150753 Approved by: https://github.com/anijain2305, https://github.com/jansel
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Pull Request resolved: pytorch#150754 Approved by: https://github.com/anijain2305, https://github.com/jansel, https://github.com/Skylion007 ghstack dependencies: pytorch#150753
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Pull Request resolved: pytorch#150755 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: pytorch#150753, pytorch#150754
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Pull Request resolved: pytorch#150828 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: pytorch#150753, pytorch#150754, pytorch#150755
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
Pull Request resolved: pytorch#151179 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: pytorch#150753, pytorch#150754, pytorch#150755, pytorch#150828
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
`optimize_assert` already does the lookup for `backend` and `backend_ctx_ctor`. This simply moves the lookups within `optimize` lower so we don't end up calling these functions twice unnecessarily in the `optimize_assert` path. Pull Request resolved: pytorch#150753 Approved by: https://github.com/anijain2305, https://github.com/jansel
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#150754 Approved by: https://github.com/anijain2305, https://github.com/jansel, https://github.com/Skylion007 ghstack dependencies: pytorch#150753
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#150755 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: pytorch#150753, pytorch#150754
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#150828 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: pytorch#150753, pytorch#150754, pytorch#150755
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Pull Request resolved: pytorch#151179 Approved by: https://github.com/anijain2305, https://github.com/Skylion007 ghstack dependencies: pytorch#150753, pytorch#150754, pytorch#150755, pytorch#150828
Divigroup-RAP
pushed a commit
to Divigroup-RAP/PYTORCH
that referenced
this pull request
Apr 22, 2025
`optimize_assert` already does the lookup for `backend` and `backend_ctx_ctor`. This simply moves the lookups within `optimize` lower so we don't end up calling these functions twice unnecessarily in the `optimize_assert` path. ghstack-source-id: 3415018 Pull Request resolved: pytorch/pytorch#150753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
optimize_assertalready does the lookup forbackendandbackend_ctx_ctor. This simply moves the lookups withinoptimizelower so we don't end up calling these functions twice unnecessarily
in the
optimize_assertpath.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames