-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Add CPython exception tests #150789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPython exception tests #150789
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150789
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit c67efe9 with merge base 31e1274 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
* test_baseexception.py * test_exceptions.py * test_exception_group.py * test_except_star.py * test_exception_variations.py * test_raise.py * test_sys.py ghstack-source-id: 618014d Pull Request resolved: pytorch/pytorch#150789
@pytorchbot revert -c nosignal -m "This is failing upstream in trunk, see https://hud.pytorch.org/pytorch/pytorch/commit/67fb9b7cc3f7d2ebbb104296f2b11776f4adbb22" |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 67fb9b7. Reverted #150789 on behalf of https://github.com/seemethere due to This is failing upstream in trunk, see https://hud.pytorch.org/pytorch/pytorch/commit/67fb9b7cc3f7d2ebbb104296f2b11776f4adbb22 ([comment](#150789 (comment)))
@guilhermeleobas your PR has been successfully reverted. |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
* test_baseexception.py * test_exceptions.py * test_exception_variations.py * test_raise.py * test_sys.py Minor changes were made to each test to run them inside Dynamo One can reproduce the changes by downloading the tests from CPython and applying the diff: ```bash for f in "test_raise" "test_sys" "test_exceptions" "test_baseexception" "test_exception_variations"; do wget -O "test/dynamo/cpython/3_13/${f}.py" "https://raw.githubusercontent.com/python/cpython/refs/heads/3.13/Lib/test/${f}.py" git apply "test/dynamo/cpython/3_13/${f}.diff" done ``` ghstack-source-id: c188289 Pull Request resolved: #150789
* test_baseexception.py * test_exceptions.py * test_exception_variations.py * test_raise.py * test_sys.py Minor changes were made to each test to run them inside Dynamo One can reproduce the changes by downloading the tests from CPython and applying the diff: ```bash for f in "test_raise" "test_sys" "test_exceptions" "test_baseexception" "test_exception_variations"; do wget -O "test/dynamo/cpython/3_13/${f}.py" "https://raw.githubusercontent.com/python/cpython/refs/heads/3.13/Lib/test/${f}.py" git apply "test/dynamo/cpython/3_13/${f}.diff" done ``` ghstack-source-id: 29b3eae Pull Request resolved: #150789
---- * test_baseexception.py * test_exceptions.py * test_exception_variations.py * test_raise.py * test_sys.py Minor changes were made to each test to run them inside Dynamo One can reproduce the changes by downloading the tests from CPython and applying the diff: ```bash for f in "test_raise" "test_sys" "test_exceptions" "test_baseexception" "test_exception_variations"; do wget -O "test/dynamo/cpython/3_13/${f}.py" "https://raw.githubusercontent.com/python/cpython/refs/heads/3.13/Lib/test/${f}.py" git apply "test/dynamo/cpython/3_13/${f}.diff" done ``` Pull Request resolved: pytorch#150789 Approved by: https://github.com/zou3519
This reverts commit 67fb9b7. Reverted pytorch#150789 on behalf of https://github.com/seemethere due to This is failing upstream in trunk, see https://hud.pytorch.org/pytorch/pytorch/commit/67fb9b7cc3f7d2ebbb104296f2b11776f4adbb22 ([comment](pytorch#150789 (comment)))
* test_baseexception.py * test_exceptions.py * test_exception_variations.py * test_raise.py * test_sys.py Minor changes were made to each test to run them inside Dynamo One can reproduce the changes by downloading the tests from CPython and applying the diff: ```bash for f in "test_raise" "test_sys" "test_exceptions" "test_baseexception" "test_exception_variations"; do wget -O "test/dynamo/cpython/3_13/${f}.py" "https://raw.githubusercontent.com/python/cpython/refs/heads/3.13/Lib/test/${f}.py" git apply "test/dynamo/cpython/3_13/${f}.diff" done ``` ghstack-source-id: 2e8d3d3 Pull Request resolved: #150789
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
Minor changes were made to each test to run them inside Dynamo
One can reproduce the changes by downloading the tests from CPython and applying the diff:
cc @albanD @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames