Skip to content

Add inductor backend to device interface; make minifier_tests more device agnostic #151314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

charlie-wt
Copy link
Contributor

@charlie-wt charlie-wt commented Apr 15, 2025

Tried to decouple the always cpu <=> c++, cuda <=> triton assumption. Tried to keep it relatively simple by just guarding things more specifically, at the moment.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

Copy link

pytorch-bot bot commented Apr 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151314

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 7617134 with merge base 2a286cb (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@charlie-wt charlie-wt marked this pull request as ready for review April 15, 2025 12:55
@charlie-wt
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 15, 2025
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 16, 2025
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! sorry I missed this earlier.

@EikanWang EikanWang added the ciflow/xpu Run XPU CI tasks label Jun 5, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/xpu Run XPU CI tasks label Jun 20, 2025
@charlie-wt
Copy link
Contributor Author

charlie-wt commented Aug 4, 2025

gonna take a look at how recent changes to the inductor config affect this

i've added a bit to try_patch_inductor_backend_config to accommodate the per-device custom configs—i'm presuming people might have their own custom config module, for their custom device with custom backend classes, and would want try_patch to work with that.

however, i still try to patch in the global config module, since all the current codegen stuff for the built-in backends on cpu/cuda will be using those objects too.

Also specify an `inductor_backend` for MTIA
@charlie-wt charlie-wt requested a review from eellison August 5, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: dynamo module: inductor open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants