Skip to content

[ONNX] Implement sym_not #152111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[ONNX] Implement sym_not #152111

wants to merge 8 commits into from

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Apr 24, 2025 •
edited
Loading

Implement onnx support for sym_not. Replaces #147472

Fix #136572

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152111

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0f76e2c with merge base e2c7ae5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Apr 24, 2025
@justinchuby justinchuby added module: onnx Related to torch.onnx release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category and removed release notes: onnx torch.onnx related changes that should show up in the release notes labels Apr 24, 2025
@titaiwangms
Copy link
Collaborator

I think there might be some authorization issue that we need to ask core maintainer to run CI.

titaiwangms
titaiwangms reviewed Apr 24, 2025
View reviewed changes
torch/onnx/_internal/exporter/_torchlib/ops/symops.py Outdated


@onnx_impl(torch.sym_not, trace_only=True)
def sym_not(self) -> BOOL:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test with dummy model to validate the op is converted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

justinchuby
justinchuby commented Apr 24, 2025
View reviewed changes
@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 25, 2025
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@titaiwangms titaiwangms added the topic: new features topic category label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category topic: new features topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ONNX] Dynamic shapes: support torch.sym_not
4 participants
@justinchuby @titaiwangms @pytorchmergebot @pytorchbot