[AUTOCAST] FEAT: Allow passing a `torch.device` object to autocast #153539

guillemc23 · 2025-05-14T13:41:29Z

Allow passing a torch.device object to the autocast constructor. It simply gets the torch.device.type in case the device_type is an instance of torch.device.

cc @mcarilli @ptrblck @leslie-fang-intel @jgong5

pytorch-bot · 2025-05-14T13:41:34Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153539

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit 98dfaa0 with merge base 79aef14 ():

NEW FAILURES - The following jobs have failed:

Lint / lintrunner-noclang / linux-job (gh)
>>> Lint for torch/_logging/structured.py:
pull / linux-jammy-cuda12.8-py3.10-gcc11 / build (gh)
pull / linux-jammy-cuda12.8-py3.10-gcc11-build-distributed / build (gh)

CANCELLED JOB - The following job was cancelled. Please retry:

pull / linux-jammy-cuda12.8-py3.10-gcc11-sm89 / build (gh)
##[error]The operation was canceled.

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable) (gh)
exir/backend/test/test_to_backend_multi_method.py::TestToBackendMultiMethod::test_multi_method_end_to_end

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2025-05-14T13:41:37Z

The committers listed above are authorized under a signed CLA.

✅ login: guillemc23 (98cfa4b)
✅ login: ezyang / name: Edward Z. Yang (bd99684, 830f9b0, 8726683, 1a73ed4, a8ac0ea, 98dfaa0)

guillemc23 · 2025-05-14T13:45:45Z

@pytorchbot label "topic: not user facing"

ezyang · 2025-06-06T01:33:06Z

@pytorchbot merge

pytorchmergebot · 2025-06-06T01:34:59Z

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#155265

Details for Dev Infra team

Raised by workflow job

ezyang · 2025-06-06T12:06:48Z

@pytorchbot merge

pytorchmergebot · 2025-06-06T12:09:15Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-06T12:09:58Z

Merge failed

Reason: 38 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ezyang · 2025-06-06T13:28:07Z

@pytorchbot merge

pytorchmergebot · 2025-06-06T13:30:53Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-06T13:36:18Z

Merge failed

Reason: 6 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2025-06-06T13:44:29Z

@pytorchbot merge

pytorchmergebot · 2025-06-06T13:46:19Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-06T13:46:29Z

Merge failed

Reason: 6 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

guillemc23 · 2025-06-08T12:19:08Z

Thank you @ezyang but I believe one of the tests is actually checking whether autocast is receiving a string, so it's not valid anymore... I guess that test should change to allow torch.device as well in other for all tests to pass...

ezyang · 2025-06-09T03:19:22Z

You sure? Sounds like I forgot to import Union.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ezyang · 2025-06-09T03:22:58Z

@pytorchbot merge

pytorchmergebot · 2025-06-09T03:25:33Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-09T03:41:36Z

Merge failed

Reason: 5 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2025-06-10T01:06:00Z

oh you were right 🤦

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ezyang · 2025-06-10T01:48:45Z

@pytorchbot merge

pytorchmergebot · 2025-06-10T01:50:39Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-10T03:09:26Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

github-actions · 2025-08-09T07:35:14Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

feat: Allow passing a torch.device object to autocast

98cfa4b

pytorch-bot bot added the module: amp (automated mixed precision) autocast label May 14, 2025

pytorch-bot bot added the topic: not user facing topic category label May 14, 2025

pytorchbot added the open source label May 14, 2025

jerryzh168 requested review from wschin and ezyang May 16, 2025 17:08

jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 16, 2025

ezyang approved these changes Jun 6, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 6, 2025

pytorchmergebot added the merging label Jun 6, 2025

pytorchmergebot removed the merging label Jun 6, 2025

pytorchmergebot added the merging label Jun 6, 2025

pytorchmergebot removed the merging label Jun 6, 2025

Use compat type syntax

830f9b0

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Jun 6, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 6, 2025

pytorchmergebot added the merging label Jun 6, 2025

pytorchmergebot removed the merging label Jun 6, 2025

pytorchmergebot added the merging label Jun 6, 2025

pytorchmergebot removed the merging label Jun 6, 2025

ezyang added 3 commits June 8, 2025 23:20

Fix

a8ac0ea

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

fixup

bd99684

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Merge remote-tracking branch 'origin/main' into autocast-torch-device

8726683

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Jun 9, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 9, 2025

pytorchmergebot added the merging label Jun 9, 2025

pytorchmergebot removed the merging label Jun 9, 2025

ezyang added 2 commits June 9, 2025 21:21

fixup

1a73ed4

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Merge remote-tracking branch 'origin/main' into autocast-torch-device

98dfaa0

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Jun 10, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 10, 2025

pytorchmergebot added the merging label Jun 10, 2025

pytorchmergebot removed the merging label Jun 10, 2025

github-actions bot added the Stale label Aug 9, 2025

[AUTOCAST] FEAT: Allow passing a torch.device object to autocast #153539

Are you sure you want to change the base?

[AUTOCAST] FEAT: Allow passing a torch.device object to autocast #153539

Uh oh!

Conversation

guillemc23 commented May 14, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153539

❌ 3 New Failures, 1 Cancelled Job, 1 Unrelated Failure

Uh oh!

linux-foundation-easycla bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guillemc23 commented May 14, 2025

Uh oh!

ezyang commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge failed

Uh oh!

ezyang commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge failed

Uh oh!

ezyang commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge failed

Uh oh!

ezyang commented Jun 6, 2025

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 6, 2025

Merge failed

Uh oh!

guillemc23 commented Jun 8, 2025

Uh oh!

ezyang commented Jun 9, 2025

Uh oh!

ezyang commented Jun 9, 2025

Uh oh!

pytorchmergebot commented Jun 9, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 9, 2025

Merge failed

Uh oh!

ezyang commented Jun 10, 2025

Uh oh!

ezyang commented Jun 10, 2025

Uh oh!

pytorchmergebot commented Jun 10, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 10, 2025

Merge failed

Uh oh!

github-actions bot commented Aug 9, 2025

Uh oh!

Uh oh!

[AUTOCAST] FEAT: Allow passing a `torch.device` object to autocast #153539

[AUTOCAST] FEAT: Allow passing a `torch.device` object to autocast #153539

guillemc23 commented May 14, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented May 14, 2025 •

edited

Loading

linux-foundation-easycla bot commented May 14, 2025 •

edited

Loading