Updates contextlib with ParamSpec #153623
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153623
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3552243 with merge base 4f4ecc5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ac1e39a to
c487ef1
Compare
42ae24d to
3552243
Compare
| """Allow a context manager to be used as a decorator without parentheses.""" | ||
|
|
||
| def __new__(cls, orig_func=None): | ||
| @overload |
There was a problem hiding this comment.
Mypy doesn't like me returning a Callable from new here, but I am not sure what is the proper way to make it happy.
There was a problem hiding this comment.
I guess this is supposed to only ever return an instance of cls ? :p
| if orig_func is None: | ||
| return super().__new__(cls) | ||
| return cls()(orig_func) | ||
| instance = super().__new__(cls) | ||
| return cast(Callable[P, R], instance(orig_func)) # type: ignore[misc] |
There was a problem hiding this comment.
I wish it was... definitely deprecated code though
| """Allow a context manager to be used as a decorator without parentheses.""" | ||
|
|
||
| def __new__(cls, orig_func=None): | ||
| @overload |
There was a problem hiding this comment.
I guess this is supposed to only ever return an instance of cls ? :p
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Should improve typing for decorators
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela