Skip to content

[dynamo, nested graph breaks] remove recursive cell/freevar in instruction tx #154078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[dynamo, nested graph breaks] remove recursive cell/freevar in instruction tx #154078

wants to merge 5 commits into from

Conversation

williamwen42
Copy link
Member

@williamwen42 williamwen42 commented May 21, 2025 •
edited
Loading

This was referenced May 17, 2025
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154078

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ebedb5b with merge base e5f6ffd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced May 17, 2025
Closed
Closed
@williamwen42 williamwen42 mentioned this pull request May 21, 2025
Open
@williamwen42 williamwen42 marked this pull request as draft May 21, 2025 22:32
@williamwen42 williamwen42 added the topic: not user facing topic category label May 21, 2025
@williamwen42
Update on "[dynamo] remove recursive cell/freevar in instruction tx"
a55536f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@williamwen42
Update on "[dynamo] remove recursive cell/freevar in instruction tx"
25362d5 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@williamwen42
Update on "[dynamo] remove recursive cell/freevar in instruction tx"
74640f0 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@williamwen42
Update on "[dynamo] remove recursive cell/freevar in instruction tx"
ebedb5b 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@williamwen42 williamwen42 marked this pull request as ready for review July 1, 2025 21:04
@williamwen42 williamwen42 changed the title [dynamo] remove recursive cell/freevar in instruction tx [dynamo, nested graph breaks] remove recursive cell/freevar in instruction tx Jul 1, 2025
StrongerXi
StrongerXi approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@StrongerXi StrongerXi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 2, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/williamwen42/241/head branch August 2, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

@StrongerXi StrongerXi StrongerXi approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamwen42 @pytorchmergebot @jansel @StrongerXi