-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Updated padding validation in max_pool functions to account for dilation #154395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154395
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit caca0c6 with merge base 839c9c6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "release notes: nn" |
@malfet can you please add reviewers to this pr? |
@jbschlosser Can you please take a look? |
Following up on this PR, @jbschlosser please take a look when you can |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
@pytorchbot remove label stale |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot label stale |
Didn't find following labels among repository labels: stale |
@pytorchbot remove label Stale |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot label stale |
@pytorchbot label Stale |
Didn't find following labels among repository labels: stale |
@pytorchbot label remove Stale |
Didn't find following labels among repository labels: remove |
@pytorchbot --help |
PyTorchBot Help
Merge
Revert
Rebase
Label
Dr CI
cherry-pick
|
@pytorchbot label no-stale |
Fixes #154262
Modified padding validation in
max_pool1d
,max_pool2d
andmax_pool3d
to use the effective kernel size (taking dilation into account).This change prevents valid padding values from being incorrectly rejected when using dilation.