Skip to content

Fix in pytorch do_bench_using_profiling #154766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JonathanHuangg
Copy link

@JonathanHuangg JonathanHuangg commented May 30, 2025

Summary:
Local testing with benchmark demonstrated a decrease in the error message frequency:

"Failed to divide all profiling events into #repeat groups. "
"#CUDA events: %d, #repeats: %s"

However, this is not a comprehensive solution and does not solve the problem every time.

Test Plan: Please refer to the next diff.

Differential Revision: D75698662

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Copy link

pytorch-bot bot commented May 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154766

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated Failures

As of commit dfc3fb5 with merge base 0f3db20 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

linux-foundation-easycla bot commented May 30, 2025

CLA Missing ID CLA Not Signed

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75698662

Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JonathanHuangg JonathanHuangg force-pushed the export-D75698662 branch 2 times, most recently from 7e190b1 to d027c08 Compare May 30, 2025 21:38
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75698662

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75698662

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75698662

JonathanHuangg pushed a commit to JonathanHuangg/pytorch that referenced this pull request May 30, 2025
Summary:
Pull Request resolved: pytorch#154766

Local testing with benchmark demonstrated a decrease in the error message frequency:

"Failed to divide all profiling events into #repeat groups. "
            "#CUDA events: %d, #repeats: %s"

However, this is not a comprehensive solution and does not solve the problem every time.

Test Plan: Please refer to the next diff.

Differential Revision: D75698662
Summary:
Pull Request resolved: pytorch#154766

Local testing with benchmark demonstrated a decrease in the error message frequency:

"Failed to divide all profiling events into #repeat groups. "
            "#CUDA events: %d, #repeats: %s"

However, this is not a comprehensive solution and does not solve the problem every time.

Test Plan: Please refer to the next diff.

Differential Revision: D75698662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75698662

Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@janeyx99 janeyx99 requested a review from desertfire August 4, 2025 23:06
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 4, 2025
@desertfire
Copy link
Contributor

@JonathanHuangg , can you describe more about the problem in a github issue?

@desertfire desertfire requested a review from eellison August 6, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor fb-exported module: inductor open source Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants