[dict] Implement __eq__ for dict_items
#155154
Open
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155154
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New Failures, 1 Pending, 3 Unrelated FailuresAs of commit ed7054c with merge base e619c6b ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 4, 2025
This was referenced Jun 9, 2025
guilhermeleobas
commented
Aug 7, 2025
Comment on lines
+1337
to
+1343
| def call_method(self, tx, name, args, kwargs): | ||
| if name == "__eq__": | ||
| assert len(args) == 1 | ||
| if isinstance(args[0], DictItemsVariable): | ||
| return self.dv_dict.call_method(tx, "__eq__", [args[0].dv_dict], {}) | ||
| return ConstantVariable.create(False) | ||
| return super().call_method(tx, name, args, kwargs) |
There was a problem hiding this comment.
This one should actually check if args[0] implements a mapping protocol and go from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
dict.update()with no args #158061fromkeysclassmethod #155608bool(OrderedDict)#155503hasattr(..., IteratorVariable)#155501__eq__for dict_items #155154OrderedDict.popitem(last=...)#155153OrderedDict.move_to_end(key, last=False)#155152set_fullgraph(False)intest_dict/test_ordered_dict#160156