Skip to content

Add UT for torch.accelerator memory-related API #155200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 43 commits into from
Closed

Add UT for torch.accelerator memory-related API #155200

wants to merge 43 commits into from
+151 −0

Conversation

guangyey
Copy link
Collaborator

@guangyey guangyey commented Jun 5, 2025 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155200

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 3 Pending, 2 Unrelated Failures

As of commit 8de213f with merge base 178515d (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 5, 2025
This was referenced Jun 5, 2025
Closed
Closed
Draft
@guangyey guangyey changed the title Add UT for torch.accelerator memory-related API [WIP] Add UT for torch.accelerator memory-related API Jun 5, 2025
@guangyey guangyey marked this pull request as draft June 5, 2025 10:14
guangyey added 22 commits June 5, 2025 14:16
@guangyey
Update
4f7c9c3 
[ghstack-poisoned]
@guangyey
Update
f45f52a 
[ghstack-poisoned]
@guangyey
Update
cceeb94 
[ghstack-poisoned]
@guangyey
Update
3629d19 
[ghstack-poisoned]
@guangyey
Update
3334537 
[ghstack-poisoned]
@guangyey
Update
a8d93ac 
[ghstack-poisoned]
@guangyey
Update
16cabd0 
[ghstack-poisoned]
@guangyey
Update
7241eac 
[ghstack-poisoned]
@guangyey
Update
c54d0ba 
[ghstack-poisoned]
@guangyey
Update
5cb73db 
[ghstack-poisoned]
@guangyey
Update
75411a4 
[ghstack-poisoned]
@guangyey
Update
2df1f32 
[ghstack-poisoned]
@guangyey
Update
616a3a2 
[ghstack-poisoned]
@guangyey
Update
d90cfc0 
[ghstack-poisoned]
@guangyey
Update
dfd314e 
[ghstack-poisoned]
@guangyey
Update
126a9d6 
[ghstack-poisoned]
@guangyey
Update
f90f105 
[ghstack-poisoned]
@guangyey
Update
2398c59 
[ghstack-poisoned]
@guangyey
Update
9d636e2 
[ghstack-poisoned]
@guangyey
Update
37c1452 
[ghstack-poisoned]
@guangyey
Update
ee38a2f 
[ghstack-poisoned]
@guangyey
Update
c5faeeb 
[ghstack-poisoned]
guangyey added 2 commits August 1, 2025 21:49
@guangyey
Update
413c938 
[ghstack-poisoned]
@guangyey
Update
ec4cd13 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

guangyey commented Aug 5, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 5, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Check mergeability of ghstack PR / ghstack-mergeability-check

Details for Dev Infra team Raised by workflow job

@guangyey
Update
7391ff2 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

guangyey commented Aug 6, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 5 checks: Check mergeability of ghstack PR / ghstack-mergeability-check, pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable), xpu / linux-jammy-xpu-2025.1-py3.9 / test (default, 2, 6, linux.idc.xpu), xpu / linux-jammy-xpu-2025.1-py3.9 / test (default, 5, 6, linux.idc.xpu), rocm / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot added a commit that referenced this pull request Aug 7, 2025
@pytorchmergebot
Revert "Add UT for torch.accelerator memory-related API (#155200)"
c4e6446 
This reverts commit 4604f04.

Reverted #155200 on behalf of https://github.com/jithunnair-amd due to Broke ROCm periodic runs on MI300 e.g. https://github.com/pytorch/pytorch/actions/runs/16764977800/job/47470050573 ([comment](#138222 (comment)))
@pytorchmergebot
Copy link
Collaborator

@guangyey your PR has been reverted as part of the stack under #138222.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Aug 7, 2025
@guangyey guangyey added the ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 label Aug 8, 2025
@guangyey
Update
8de213f 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

guangyey commented Aug 8, 2025

ciflow/periodic-rocm-mi300 has passed in https://github.com/pytorch/pytorch/actions/runs/16825579652/job/47683968293?pr=155200
Try to reland this stack of PRs.
@pytorchbot merge -f "skip XPU unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

hinriksnaer pushed a commit to hinriksnaer/pytorch that referenced this pull request Aug 8, 2025
@guangyey @hinriksnaer
Add UT for torch.accelerator memory-related API (pytorch#155200)
203dd02 
Pull Request resolved: pytorch#155200
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#138222, pytorch#152932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang EikanWang is a code owner

@gujinghui gujinghui Awaiting requested review from gujinghui gujinghui is a code owner

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/mps Run MPS tests (subset of trunk) ciflow/periodic-rocm-mi300 Trigger "distributed" config CI on ROCm MI300 ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: accelerator Issues related to the shared accelerator API open source Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guangyey @pytorchmergebot @albanD @pytorchbot