Skip to content

Try running test_foreach sequentially #155366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jun 6, 2025

test_foreach.py::TestForeachCUDA::test_parity starts failing consistently in trunk, but I couldn't reproduce the issue locally or on CI (ssh into the runner) https://hud.pytorch.org/hud/pytorch/pytorch/main/1?per_page=50&name_filter=g6

So, I suspect that running tests in parallel has a side effect here. Disable utilization monitoring to see if it fixs the issue. The other CI change I know is jammy upgrade #154437

Fixes #151228 (I disabled this test and another test_parity failure shows up)

Signed-off-by: Huy Do <huydhn@gmail.com>
Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155366

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 27bf6cf with merge base 1ccc57e (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 6, 2025
@huydhn huydhn added the no-runner-experiments Bypass Meta/LF runner determinator label Jun 6, 2025
Signed-off-by: Huy Do <huydhn@gmail.com>
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DISABLED test_parity__foreach_add_fastpath_inplace_cuda_bfloat16 (__main__.TestForeachCUDA)
1 participant