[export] inline into torch.jit.traced nn module #155381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155381
Note: Links to docs will display an error until the docs builds have been completed. ❌ 31 New Failures, 1 Unrelated FailureAs of commit 8986294 with merge base 3f34d26 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @@ -260,7 +260,6 @@ def make_fake_inputs( | |||
| args, | |||
| kwargs, | |||
| dynamic_shapes, | |||
| _is_torch_jit_trace=False, | |||
| def __init__(self, mod): | ||
| self.mod = mod | ||
|
|
||
| script_module._orig_module = Wrapped(obj) |
There was a problem hiding this comment.
Why do we need to wrap it?
| @@ -1318,6 +1318,7 @@ def register_submods(mod, prefix): | |||
| finally: | |||
| torch.jit._trace._trace_module_map = old_module_map | |||
|
|
|||
| module.forward._original_forward = mod.forward | |||
There was a problem hiding this comment.
probably should put a comment explaining this change. How does serializing/deserializing work here?
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel