Skip to content

Remove unnecessary MPSStream initialization #155602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unnecessary MPSStream initialization #155602

wants to merge 2 commits into from
+1 −2

Conversation

skotapati
Copy link
Collaborator

@skotapati skotapati commented Jun 10, 2025 •
edited
Loading

Uncovered a small memory leak as part of the investigation into #154329.

The call to MPSStream was orphaned by https://github.com/pytorch/pytorch/pull/85817/files#diff-6ca28430ea5963cd324d8fb17f3052ae0cb8c5a96369965491cb69bab08ab0beL38. Removing it as it's now unnecessary and was causing memory leaks

This resolves about 30% of the remaining memory growth from the linked issue

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155602

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3069801 with merge base cb9b479 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jun 10, 2025
@skotapati skotapati changed the title Remove unnecessary MPSStream initialization which was causing memory leaks Remove unnecessary MPSStream initialization Jun 10, 2025
@skotapati skotapati mentioned this pull request Jun 11, 2025
Open
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 13, 2025
@djphoenix djphoenix mentioned this pull request Jul 19, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) open source release notes: mps Release notes category Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skotapati @pytorchbot @janeyx99