-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[Scripts] Add refresh script to clean, pull and build repo #155639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155639
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6da3934 with merge base c4b93e6 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
scripts/refresh.sh
Outdated
|
||
# Pull and build | ||
echo "Pulling latest version" | ||
git pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you're not checking out a new revision, what is pull doing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, that can be done by the user outside of this script.
echo "Updating submodules" | ||
git submodule update --init --recursive | ||
echo "Building" | ||
python setup.py develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally we build with various flags like
TORCH_CUDA_ARCH_LIST="9.0" USE_XNNPACK=0 USE_FBGEMM=0 USE_QNNPACK=0 USE_MKLDNN=0 USE_MIOPEN=0 USE_NNPACK=0 BUILD_CAFFE2_OPS=0 USE_GOLD_LINKER=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want these standardized for everyone? cc @seemethere
e799931
to
6da3934
Compare
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Been bugging me that there's no good one-shot command to update and rebuild when switching branches. (Correct me if there is.) This script should serve as a starting point; more options can be integrated in the future.
Test plan: Tested on OSS PyTorch repo on devserver